From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 2A3671FF183 for ; Wed, 21 May 2025 13:12:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 452BA163CD; Wed, 21 May 2025 13:12:44 +0200 (CEST) Message-ID: Date: Wed, 21 May 2025 13:12:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: pve-devel@lists.proxmox.com References: <20250513124622.71270-1-s.shaji@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250513124622.71270-1-s.shaji@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [flutter.dev] Subject: Re: [pve-devel] [PATCH proxmox_login_manager] refactor: rename `MaterialState` to `WidgetState` X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" not a super big issue, but 2 hunks seem to be unrelated to the commit message (see inline) it would be much nicer to have the commits clean, so I'd appreciate it when you send a v2 that either * has separate patches for the different things (i would much prefer that) * change the commit message to include what is fixed/improved On 5/13/25 14:46, Shan Shaji wrote: > This commit applys the `dart fix` command to fix all the dart > analysis issues associated with renaming `MaterialState` to > `WidgetState`. > > According to the flutter official docs [0] the `MaterialState` and it's > related APIs have been moved out of the material library and renamed to > `WidgetState`. The behaviour of the two are the same. > > - [0] https://docs.flutter.dev/release/breaking-changes/material-state > > Signed-off-by: Shan Shaji > --- > lib/proxmox_login_form.dart | 34 ++++++++++++++++----------------- > lib/proxmox_login_selector.dart | 2 +- > 2 files changed, 18 insertions(+), 18 deletions(-) > > diff --git a/lib/proxmox_login_form.dart b/lib/proxmox_login_form.dart > index 735bd42..06a57e1 100644 > --- a/lib/proxmox_login_form.dart > +++ b/lib/proxmox_login_form.dart > @@ -257,46 +257,46 @@ class _ProxmoxLoginPageState extends State { > secondary: ProxmoxColors.orange, > onSecondary: ProxmoxColors.supportGrey), > checkboxTheme: CheckboxThemeData( > - fillColor: MaterialStateProperty.resolveWith( > - (Set states) { > - if (states.contains(MaterialState.disabled)) { > + fillColor: WidgetStateProperty.resolveWith( > + (Set states) { > + if (states.contains(WidgetState.disabled)) { > return null; > } > - if (states.contains(MaterialState.selected)) { > + if (states.contains(WidgetState.selected)) { > return ProxmoxColors.orange; > } > return null; > }), > ), > radioTheme: RadioThemeData( > - fillColor: MaterialStateProperty.resolveWith( > - (Set states) { > - if (states.contains(MaterialState.disabled)) { > + fillColor: WidgetStateProperty.resolveWith( > + (Set states) { > + if (states.contains(WidgetState.disabled)) { > return null; > } > - if (states.contains(MaterialState.selected)) { > + if (states.contains(WidgetState.selected)) { > return ProxmoxColors.orange; > } > return null; > }), > ), > switchTheme: SwitchThemeData( > - thumbColor: MaterialStateProperty.resolveWith( > - (Set states) { > - if (states.contains(MaterialState.disabled)) { > + thumbColor: WidgetStateProperty.resolveWith( > + (Set states) { > + if (states.contains(WidgetState.disabled)) { > return null; > } > - if (states.contains(MaterialState.selected)) { > + if (states.contains(WidgetState.selected)) { > return ProxmoxColors.orange; > } > return null; > }), > - trackColor: MaterialStateProperty.resolveWith( > - (Set states) { > - if (states.contains(MaterialState.disabled)) { > + trackColor: WidgetStateProperty.resolveWith( > + (Set states) { > + if (states.contains(WidgetState.disabled)) { > return null; > } > - if (states.contains(MaterialState.selected)) { > + if (states.contains(WidgetState.selected)) { > return ProxmoxColors.orange; > } > return null; > @@ -729,7 +729,7 @@ class ProxmoxProgressOverlay extends StatelessWidget { > @override > Widget build(BuildContext context) { > return Container( > - decoration: BoxDecoration(color: Colors.black.withOpacity(0.5)), > + decoration: BoxDecoration(color: Colors.black.withValues(alpha: 0.5)), this is not part of the `dart fix` output, but just a deprecation AFAICS > child: Center( > child: Column( > mainAxisAlignment: MainAxisAlignment.center, > diff --git a/lib/proxmox_login_selector.dart b/lib/proxmox_login_selector.dart > index f063699..e5741f2 100644 > --- a/lib/proxmox_login_selector.dart > +++ b/lib/proxmox_login_selector.dart > @@ -31,7 +31,7 @@ class _ProxmoxLoginSelectorState extends State { > Widget build(BuildContext context) { > return SafeArea( > child: Scaffold( > - backgroundColor: Theme.of(context).colorScheme.background, > + backgroundColor: Theme.of(context).colorScheme.surfaceContainer, this is part of `dart fix` but unrelated to the commit message, as you only mentioned the MaaterialState -> WidgetState change > appBar: AppBar( > title: const Column( > crossAxisAlignment: CrossAxisAlignment.start, _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel