From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <p.hufnagl@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BDA60EAB9 for <pve-devel@lists.proxmox.com>; Wed, 27 Sep 2023 10:57:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8F22D9FF0 for <pve-devel@lists.proxmox.com>; Wed, 27 Sep 2023 10:57:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 27 Sep 2023 10:57:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C767848D44 for <pve-devel@lists.proxmox.com>; Wed, 27 Sep 2023 10:57:09 +0200 (CEST) Message-ID: <d0e67a78-5ddb-2aef-42fc-902c02320053@proxmox.com> Date: Wed, 27 Sep 2023 10:57:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com>, =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= <f.gruenbichler@proxmox.com> References: <20230921130917.2000926-1-p.hufnagl@proxmox.com> <20230921130917.2000926-2-p.hufnagl@proxmox.com> <6aab04ab-2d39-42ac-b389-8e563c7322d0@proxmox.com> <33dd55b3-3fd3-2cca-5a3a-361d490da688@proxmox.com> <2359ccf4-f8f8-479f-8a24-b6a76ad950a5@proxmox.com> From: Philipp Hufnagl <p.hufnagl@proxmox.com> In-Reply-To: <2359ccf4-f8f8-479f-8a24-b6a76ad950a5@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.704 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.473 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 27 Sep 2023 08:57:40 -0000 On 9/27/23 10:33, Thomas Lamprecht wrote: > Am 27/09/2023 um 10:03 schrieb Philipp Hufnagl: >>> There are code paths where $filename is not yet defined here, resulting >>> in a rather ugly warning – so this needs upfront checking too – always >>> check where the value code path is coming in (yeah, Rust would do that for >>> you, but most API endpoints are small enough to be able to do so quickly also manually) >> >> I will make a new patch resolving this issue. While I am on it, I see >> what I can resolve on the other issues. > > FYI, I have a pretty much done patch for this already here, so if > you did not have anything (close to) already finished, I could push > that out – just mentioning to avoid potential duplicate work. I have nothing close. Sorry for the inconvenience and thank you for fixing.