From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0AF4E1FF0AA for ; Tue, 03 Nov 2026 15:47:58 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D615C218AD; Tue, 03 Nov 2026 15:47:55 +0100 (CET) Message-ID: Date: Tue, 3 Nov 2026 15:47:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH perl-rs] oci: update doc comment of parse_and_extract_image From: Filip Schauer To: pve-devel@lists.proxmox.com References: <20261103144546.271947-1-f.schauer@proxmox.com> Content-Language: en-US In-Reply-To: <20261103144546.271947-1-f.schauer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793717271956 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.361 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LXWYADMSPYBVG4BDF5RGUOM5MHOAZQZ4 X-Message-ID-Hash: LXWYADMSPYBVG4BDF5RGUOM5MHOAZQZ4 X-MailFrom: f.schauer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This belongs to the proxmox-perl-rs repository. On 03/11/2026 15:46, Filip Schauer wrote: > The function does not return the entire image config, only the optional > execution parameters contained in the image config. > > Signed-off-by: Filip Schauer > --- > This is the same thing as 9b5bf494b175 in proxmox.git. > > pve-rs/src/bindings/oci.rs | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/pve-rs/src/bindings/oci.rs b/pve-rs/src/bindings/oci.rs > index 7f5acaf..30e74fd 100644 > --- a/pve-rs/src/bindings/oci.rs > +++ b/pve-rs/src/bindings/oci.rs > @@ -7,7 +7,7 @@ pub mod pve_rs_oci { > use anyhow::Error; > use proxmox_oci::Config; > > - /// Extract the rootfs of an OCI image tar and return the image config. > + /// Extract the rootfs of an OCI image tar and return its execution parameters. > /// > /// # Arguments > /// > @@ -15,6 +15,11 @@ pub mod pve_rs_oci { > /// * `rootfs_path` - Destination path where the rootfs will be extracted to > /// * `arch` - Optional CPU architecture used to pick the first matching manifest from a multi-arch > /// image index. If `None`, the first manifest will be used. > + /// > + /// # Returns > + /// > + /// On success, this returns the optional container execution parameters > + /// if present in the image configuration. > #[export] > pub fn parse_and_extract_image( > oci_tar_path: &str,