From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9B1BF8D2CE for <pve-devel@lists.proxmox.com>; Mon, 7 Nov 2022 16:43:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 71E802D9A7 for <pve-devel@lists.proxmox.com>; Mon, 7 Nov 2022 16:42:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Mon, 7 Nov 2022 16:42:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8442A421FC for <pve-devel@lists.proxmox.com>; Mon, 7 Nov 2022 16:42:43 +0100 (CET) Message-ID: <d0b0a14c-cf4e-8aad-833e-de3f7c1dbde7@proxmox.com> Date: Mon, 7 Nov 2022 16:42:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20221107150750.2320248-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20221107150750.2320248-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH http-server v2 1/2] upload: allow whitespaces in filenames X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 07 Nov 2022 15:43:14 -0000 Am 07/11/2022 um 16:07 schrieb Dominik Csapak: > some fields (e.g. filename) can contain spaces, but our 'trim' function, > would only return the value until the first whitespace character instead > of removing leading/trailing white space. this lead to giving the wrong > filename to the api call (e.g. 'foo' instead of 'foo (1).iso') which > would reject it because of the 'wrong' extension > > this patch fixes that by using trim from pve-common > > fixes commit: > 0fbcbc2 ("fix #3990: multipart upload: rework to fix uploading small files") > > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> > --- > src/PVE/APIServer/AnyEvent.pm | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > applied, thanks!