From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 483BE1FF179 for ; Wed, 10 Dec 2025 12:02:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 88CE419240; Wed, 10 Dec 2025 12:02:59 +0100 (CET) Message-ID: Date: Wed, 10 Dec 2025 12:02:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: pve-devel@lists.proxmox.com References: <20251210101006.37654-1-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20251210101006.37654-1-f.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765364539432 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [dbusvmstate.pm] Subject: Re: [pve-devel] [PATCH qemu-server] dbus-vmstate: workaround method call on dbus object resolving to wrong instance X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 10.12.25 um 11:10 AM schrieb Fiona Ebner: > diff --git a/src/PVE/QemuServer/DBusVMState.pm b/src/PVE/QemuServer/DBusVMState.pm > index a72d6dd2..823a75ba 100644 > --- a/src/PVE/QemuServer/DBusVMState.pm > +++ b/src/PVE/QemuServer/DBusVMState.pm > @@ -114,9 +114,12 @@ sub qemu_del_dbus_vmstate { > $num_entries = eval { > dbus_get_property($object, 'com.proxmox.VMStateHelper', 'NumMigratedEntries'); > }; > - eval { $object->Quit() }; > + # NOTE: for some reason, $object->Quit() does not resolve to the correct handler even > + # though we matched the 'Id' property. As a stop-gap until this is figured out, do it > + # via systemctl. > + eval { PVE::Tools::run_command(['systemctl', 'stop', "pve-dbus-vmstate\@$vmid"]) }; > if (my $err = $@) { > - syslog('warn', "failed to call quit on dbus-vmstate for VM $vmid: $err\n") > + syslog('warn', "failed to stop pve-dbus-vmstate service for VM $vmid: $err\n") > if !$params{quiet}; > } > Hmm, maybe this is by design. We already have a helper for accessing the properties, probably we need something similar for calling methods: > # Retrieves a property from an object from a specific interface name. > # In contrast to accessing the property directly by using $obj->Property, this > # actually respects the owner of the object and thus can be used for interfaces > # with might have multiple (queued) owners on the DBus. > my sub dbus_get_property { > my ($obj, $interface, $name) = @_; > > my $con = $obj->{service}->get_bus()->get_connection(); > > my $call = $con->make_method_call_message( > $obj->{service}->get_service_name(), > $obj->{object_path}, > 'org.freedesktop.DBus.Properties', > 'Get', > ); > > $call->set_destination($obj->get_service()->get_owner_name()); > $call->append_args_list($interface, $name); > > my @reply = $con->send_with_reply_and_block($call, 10 * 1000)->get_args_list(); > return $reply[0]; > } _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel