From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C9E091FF187 for ; Mon, 14 Jul 2025 11:04:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E2B8A11E36; Mon, 14 Jul 2025 11:05:39 +0200 (CEST) Message-ID: Date: Mon, 14 Jul 2025 11:05:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Shannon Sterz , Proxmox VE development discussion References: <20250714083838.68483-1-a.lauterer@proxmox.com> <20250714083838.68483-3-a.lauterer@proxmox.com> From: Aaron Lauterer In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pveceph.pm] Subject: Re: [pve-devel] [PATCH v2 3/3] pveceph: print repo metadata when installing from manual X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 2025-07-14 10:45, Shannon Sterz wrote: > On Mon Jul 14, 2025 at 10:38 AM CEST, Aaron Lauterer wrote: >> By printing the site and component, the person installing it manuall has >> a final check to see if the correct repository is being used. >> >> Signed-off-by: Aaron Lauterer >> --- >> >> Notes: >> I intially tried to get the repo definition similar to how it is in the >> .list file and printed by apt-cache policy {package} but failed so far, >> getting that info via AptPkg::Cache. Therefore, I used what I found so far. >> >> changes since v1: >> * rebased to new indentation >> >> PVE/CLI/pveceph.pm | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm >> index a949582e..04c16199 100755 >> --- a/PVE/CLI/pveceph.pm >> +++ b/PVE/CLI/pveceph.pm >> @@ -240,7 +240,6 @@ EOF >> }; >> >> if ($repo eq "manual") { >> - # TODO: get used repo metadata and print it as additional info > > nit: you add this comment in the first patch of the series just to > remove it again here. might want to clean that up if another version of > this series is necessary. My intention here was that I am not sure if we actually want to use patch 3, as it only adds informational output, but is not strictly necessary. So if we don't use patch3, we still have the TODO around :)> >> my $apt_cache = AptPkg::Cache->new() || die "unable to initialize AptPkg::Cache\n"; >> my @ceph_versions = $apt_cache->{'ceph-common:amd64'}->{'VersionList'}->@*; >> my $latest_available = $ceph_versions[0]->{'VerStr'}; >> @@ -250,6 +249,12 @@ EOF >> die >> "Selected Ceph version '${selected_version}' does not match the available version in the repository '${latest_available}' \n" >> if ($latest_available !~ "^$selected_version"); >> + >> + my $pkg_infos = $ceph_versions[0]->{'FileList'}->[0]->{'File'}; >> + print "\nUsing the following manual repository:\n" >> + . "Site:\t\t $pkg_infos->{'Site'}\n" >> + . "Component:\t $pkg_infos->{'Component'}\n\n"; >> + >> } >> >> my @apt_install = > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel