From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 510531FF16B for ; Tue, 29 Jul 2025 13:43:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6E6E410133; Tue, 29 Jul 2025 13:44:35 +0200 (CEST) Message-ID: Date: Tue, 29 Jul 2025 13:44:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Friedrich Weber References: <20250729113523.72332-1-f.weber@proxmox.com> <20250729113523.72332-2-f.weber@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20250729113523.72332-2-f.weber@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753789463104 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH http-server 1/1] api server: proxy config: read MAX_WORKERS integer key X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 29.07.25 um 13:35 schrieb Friedrich Weber: > Read the MAX_WORKERS value in /etc/default/. If it is not > an integer, ignore and warn. > > Signed-off-by: Friedrich Weber > --- > src/PVE/APIServer/Utils.pm | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/PVE/APIServer/Utils.pm b/src/PVE/APIServer/Utils.pm > index 1430c98..f2c4892 100644 > --- a/src/PVE/APIServer/Utils.pm > +++ b/src/PVE/APIServer/Utils.pm > @@ -28,6 +28,7 @@ sub read_proxy_config { > $shcmd .= 'echo \"DISABLE_TLS_1_3:\$DISABLE_TLS_1_3\";'; > $shcmd .= 'echo \"PROXY_REAL_IP_HEADER:\$PROXY_REAL_IP_HEADER\";'; > $shcmd .= 'echo \"PROXY_REAL_IP_ALLOW_FROM:\$PROXY_REAL_IP_ALLOW_FROM\";'; > + $shcmd .= 'echo \"MAX_WORKERS:\$MAX_WORKERS\";'; > > my $data = -f $conffile ? `bash -c "$shcmd"` : ''; > > @@ -77,6 +78,12 @@ sub read_proxy_config { > push @$ips, Net::IP->new(normalize_v4_in_v6($ip)) || die Net::IP::Error() . "\n"; > } > $res->{$key} = $ips; > + } elsif ($key eq 'MAX_WORKERS') { > + if ($value =~ /^\d+$/) { > + $res->{$key} = int($value); Could be great to do some basic range checks, like > 0 and < 128 (as not low, but also not huge upper limit for starters). FWIW, rest looks pretty straight forward and really not much extra code, so would be fine for me to do it this way. > + } else { > + warn "MAX_WORKERS specified in $conffile is not an integer: $value\n"; > + } > } elsif (grep { $key eq $_ } @$boolean_options) { > die "unknown value '$value' - use 0 or 1\n" if $value !~ m/^(0|1)$/; > $res->{$key} = $value; _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel