Re: [PATCH pve-network 6/9] fix #7294: sdn: vnet: update pool members on vnet migration and deletion

[Gabriel Goller <g.goller@proxmox.com>]

On 12.06.2026 08:37, David Riley wrote:
> 
> On 6/11/26 6:21 PM, Gabriel Goller wrote:
> > On 2026-06-11 16:59 +0200, David Riley wrote:
> > > Update or remove corresponding resource pool allocations in user.cfg
> > > whenever a VNet is altered or deleted. This prevents stale paths and
> > > dangling references from breaking the configuration integrity.
> > > 
> > > Link: https://bugzilla.proxmox.com/show_bug.cgi?id=7294
> > > Signed-off-by: David Riley <d.riley@proxmox.com>
> > > ---
> > This patch doesn't apply on latest master.
> 
> Thanks for taking a look at it.
> You are completely right that it fails on the current master. As mentioned in the
> cover letter, this series depends on my earlier patch series [0].
> Just tested it locally and it should apply cleanly after applying this series first.
> 
> [0] https://lore.proxmox.com/pve-devel/20260603145523.120075-1-d.riley@proxmox.com/

Turns out I can't read.
Sorry for the noise.

> > >   src/PVE/Network/SDN.pm | 15 +++++++++++++++
> > >   1 file changed, 15 insertions(+)
> > > 
> > > diff --git a/src/PVE/Network/SDN.pm b/src/PVE/Network/SDN.pm
> > > index 6a49621..1541f8e 100644
> > > --- a/src/PVE/Network/SDN.pm
> > > +++ b/src/PVE/Network/SDN.pm
> > > @@ -259,11 +259,26 @@ sub cleanup {
> > >           PVE::AccessControl::migrate_sdn_resource_access($vnet_move_paths);
> > >       }
> > > +    foreach my $move (@$vnet_move_paths) {
> > > +        my ($src_type, $src_zone, $vnet) = @{ $move->{src_path} };
> > > +        my ($dest_type, $dest_zone, $dest_vnet) = @{ $move->{dest_path} };
> > > +
> > > +        if (defined($src_type) && $src_type eq 'zones' && $src_zone && $vnet && $dest_zone) {
> > > +            PVE::AccessControl::migrate_vnet_zone_in_pool($src_zone, $dest_zone, $vnet);
> > > +        }
> > > +    }
> > > +
> > >       my @paths_to_delete = (@$vnet_delete_paths, @$route_map_paths, @$generic_paths);
> > >       if (@paths_to_delete) {
> > >           PVE::AccessControl::remove_sdn_resource_access(\@paths_to_delete);
> > >       }
> > > +    foreach my $path (@$vnet_delete_paths) {
> > > +        my ($type, $zone, $vnet) = @$path;
> > > +        if ($type && $type eq 'zones' && $zone && $vnet) {
> > > +            PVE::AccessControl::remove_vnet_from_pool($zone, $vnet);
> > > +        }
> > > +    }
> > >   }
> > >   sub diff_generic_resources {
> > > -- 
> > > 2.47.3
> > > 
> > > 
> > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> >