From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 040D21FF183 for ; Wed, 27 Aug 2025 14:37:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D233C192FA; Wed, 27 Aug 2025 14:37:03 +0200 (CEST) Date: Wed, 27 Aug 2025 14:36:28 +0200 From: Wolfgang Bumiller To: Christian Ebner Message-ID: References: <20250827094633.239975-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250827094633.239975-1-c.ebner@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756298183722 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [main.rs, proxmox.com, lib.rs, fs.rs, compat.rs, pxarcmd.rs, sync.rs, aio.rs, mod.rs] Subject: [pbs-devel] applied-series: [PATCH pxar 0/3] pxar: make payload reference offset checks stricter X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: pbs-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" applied, thanks On Wed, Aug 27, 2025 at 11:46:30AM +0200, Christian Ebner wrote: > This patch series aims to block the encoding of possible corrupt split > pxar archives due to the payload reference offsets not being strict > monotonically increasing. This is a requirement for the sequential > decoder to be able to restore the contents from a sequential stream. > > This should also help to detect more corrupt encodings as reported in > the community forum and therefore narrow down the still lingering > logical issue, still under investigation. > > First two patches are style cleanups only, the third contains the > stricter encoder check. > > [0] https://forum.proxmox.com/threads/170211/ > > pxar: > > Christian Ebner (3): > tree wide: fix formatting via `cargo fmt` > tree wide: elide explicit lifetimes reported by cargo clippy > encoder: improve consistency check for payload reference offsets > > examples/pxarcmd.rs | 2 +- > src/accessor/aio.rs | 4 +-- > src/accessor/mod.rs | 6 ++-- > src/accessor/read_at.rs | 6 ++-- > src/accessor/sync.rs | 8 ++--- > src/decoder/aio.rs | 2 +- > src/decoder/mod.rs | 6 ++-- > src/decoder/sync.rs | 2 +- > src/encoder/aio.rs | 4 +-- > src/encoder/mod.rs | 76 +++++++++++++++++++++++++++++------------ > src/encoder/sync.rs | 4 +-- > src/lib.rs | 2 +- > tests/compat.rs | 2 +- > tests/simple/fs.rs | 8 ++--- > tests/simple/main.rs | 4 +-- > 15 files changed, 85 insertions(+), 51 deletions(-) > > > Summary over all repositories: > 15 files changed, 85 insertions(+), 51 deletions(-) > > -- > Generated by git-murpp 0.8.1 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel