From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 06ECE1FF15C for ; Fri, 3 Oct 2025 16:52:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E753C7019; Fri, 3 Oct 2025 16:52:58 +0200 (CEST) Message-ID: Date: Fri, 3 Oct 2025 16:52:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox Backup Server development discussion , Shannon Sterz References: <20251002075706.20324-1-s.sterz@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20251002075706.20324-1-s.sterz@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759503151000 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox v3] login: use `ticket` if both it and `ticket_info` are provided X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 10/2/25 9:57 AM, Shannon Sterz wrote: > previously the precense of `ticket_info` was assumed to indicate the > HTTPOnly authentication flow. the `ticket` field was ignore in that > case, because the client has no way of validating a ticket anyway. > > this commit changes the behaviour to assume that the server is not > trying to "trick us" and that the presence of a `ticket` field > indicates that this value should be used for authentication. if the > `ticket_info` field is also present, it will be ignored. > > this fixes an issue where authentication against later versions of > proxmox-backup-server 3.4 failed. including versions up to and > including version 3.4.6-1. > > Signed-off-by: Shannon Sterz > --- LGTM now! Consider: Reviewed-by: Christian Ebner Tested-by: Christian Ebner _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel