From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 7D1B91FF16B for ; Thu, 20 Feb 2025 16:28:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D593B16D5B; Thu, 20 Feb 2025 16:28:00 +0100 (CET) Message-ID: Date: Thu, 20 Feb 2025 16:27:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Wolfgang Bumiller References: <20250220120920.196450-1-c.ebner@proxmox.com> <20250220120920.196450-2-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] fix #6185: client/docs: explicitly mention archive name restrictions X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: pbs-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 2/20/25 16:22, Wolfgang Bumiller wrote: > On Thu, Feb 20, 2025 at 01:09:20PM +0100, Christian Ebner wrote: >> Mention in the docs and the api parameter description the limitations >> for archive name labels. They must contain alphanumerics, hyphens and >> underscores only to match the regex pattern. >> >> By setting this in the api parameter description, it will be included >> in the man page for proxmox-backup-client. >> >> Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=6185 >> Signed-off-by: Christian Ebner >> --- >> docs/backup-client.rst | 1 + >> pbs-client/src/backup_specification.rs | 10 ++++++---- >> proxmox-backup-client/src/main.rs | 3 ++- >> 3 files changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/docs/backup-client.rst b/docs/backup-client.rst >> index 1c2a98ed8..e11c0142a 100644 >> --- a/docs/backup-client.rst >> +++ b/docs/backup-client.rst >> @@ -169,6 +169,7 @@ the client. The format is: >> >> .: >> >> +The ``archive-name`` must contain alphanumerics, hyphens and underscores only. >> Common types are ``.pxar`` for file archives and ``.img`` for block >> device images. To create a backup of a block device, run the following command: >> >> diff --git a/pbs-client/src/backup_specification.rs b/pbs-client/src/backup_specification.rs >> index b6fbc555c..ebf7f3f18 100644 >> --- a/pbs-client/src/backup_specification.rs >> +++ b/pbs-client/src/backup_specification.rs >> @@ -7,10 +7,12 @@ const_regex! { >> BACKUPSPEC_REGEX = r"^([a-zA-Z0-9_-]+\.(pxar|img|conf|log)):(.+)$"; >> } >> >> -pub const BACKUP_SOURCE_SCHEMA: Schema = >> - StringSchema::new("Backup source specification ([