From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E4D521FF187 for ; Fri, 2 Jan 2026 16:35:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9CEC9E453; Fri, 2 Jan 2026 16:36:38 +0100 (CET) Message-ID: Date: Fri, 2 Jan 2026 16:36:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260102143544.354066-1-m.sandoval@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1767368163989 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH guest-common/qemu-server v4 0/9] fix #1964: add setting to always disable freezing a guest's fs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 02.01.26 um 4:26 PM schrieb Maximiliano Sandoval: > Maximiliano Sandoval writes: > >> ..and add more logging when issuing fsfreeze guest commands. >> >> The new setting takes precedence over freeze-fs-on-backup and deprecates the >> former. >> >> - At the moment taking a snapshot without RAM does not log whether there was a >> freeze/thaw, we add logs when issuing freezes/thaws. >> >> - The patch does not result in an extra log line when making a Backup in >> snapshot mode. >> >> - When it is easy to do so, we log if the fsfreeze command was not issued due to >> mismatch between the agent running and the config, e.g. when say that we >> skipped it if the agent is enabled bu the configuration says we shouldn't. > > @fiona, one thing I just noticed is that `import_from_volid` calls > clone_disk() with $src_config->{'agent'} as an argument. > > - Is this OK as-is, or should it also take into account the new > guest-fsfreeze setting? > - What operations would trigger this codepath? Good catch! I think it should also take into account the new setting, since it's also intended to be used in situation where freeze might not even work correctly. The code path is reached when updating a disk key using the 'import-from' property with the source volume being currently attached to a running VM. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel