From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A2B5F6987E for ; Sat, 14 Nov 2020 01:31:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 92C891F794 for ; Sat, 14 Nov 2020 01:31:30 +0100 (CET) Received: from smtp5-g21.free.fr (smtp5-g21.free.fr [IPv6:2a01:e0c:1:1599::14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B58C31F77D for ; Sat, 14 Nov 2020 01:31:28 +0100 (CET) Received: from smtp.lgy.fr (unknown [82.64.218.25]) by smtp5-g21.free.fr (Postfix) with ESMTPS id F224C5FEF7; Sat, 14 Nov 2020 01:31:15 +0100 (CET) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lgy.fr; s=dkim; t=1605313873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4BeSCR6Rw5rpB19ed2WNyvcYe3m8opCJ/IyEePkW9Q4=; b=kxnQnzoh99S/4tqTljYNUSuOnSFv28ALkO/lOOZl5pfdyB8MYCKTB715Kw/Drko5pTHhlZ AtE6Y78uWhT/zZQv+8uPEyQvQ81HfCoDSyVLu66zXFKGtVDd2AJNYyKLD7dqXCc52pIiQo Ui0deHOyp4YDbQ+tJE0R33i7WwPLL8E= From: Thomas To: Stoiko Ivanov Cc: Proxmox VE development discussion Date: Sat, 14 Nov 2020 01:31:10 +0100 In-Reply-To: <20201113151210.02c9de62@rosa.proxmox.com> References: <20201112184839.391060-1-thomas@lgy.fr> <20201113151210.02c9de62@rosa.proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.001 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain HTML_MESSAGE 0.001 HTML included in message RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record T_SPF_PERMERROR 0.01 SPF: test of record failed (permerror) Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [pve-devel] [Allow snapshot backup with glusterfs 0/1] X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2020 00:31:30 -0000 Hi Thank for your review. When i backup lxc with glusterfs mount point, backup never finish.I understant that you can disableit without rationale and maybe it's a bad way to resolve this issue.I need to create ticket in bugzilla? on function sync_container_namespace the bellow loop is never exit.while (waitpid($child, 0) != $child) {} There is no fail and no error message. When i use bash command in lxc "sync /mount/point" there is no issue.But You can find bellow step to reproduce : ---------------------------------------create lxc with name g1 with - debian 10 template - on lvmthin pool storage - privilegied conteneur - dhcp for configuration phase - exemple lxc id = 125 LXCG1=125LXCG2=126 pct start $LXCG1pct enter $LXCG1apt-get updateapt install glusterfs- server -yapt cleansystemctl enable glusterd mkdir -p /data/glusterfs #add the 2 line in /etc/hostscat << EOF >> /etc/hosts10.10.10.1 g1 10.10.10.2 g2 EOF poweroff pct clone $LXCG1 $LXCG2 --hostname g2pct set $LXCG1 --net0 name=eth0,bridge=vmbr0,ip=10.10.10.1/24pct set $LXCG2 --net0 name=eth0,bridge=vmbr0,ip=10.10.10.2/24pct set $LXCG1 --features fuse=0,mknod=0 pct start $LXCG1pct start $LXCG2pct enter $LXCG1gluster peer probe g2gluster volume create glusterfsvolume replica 2 g1:/data/glusterfs g2:/data/glusterfs forcegluster volume start glusterfsvolume mkdir /mnt/tmp/mount -t glusterfs g1:/glusterfsvolume /mnt/tmp vzdump $LXCG2 #work vzdump $LXCG1 #never finish------------------------------------------ --- Le vendredi 13 novembre 2020 à 15:12 +0100, Stoiko Ivanov a écrit : > Hi, > Thank you for contributing to PVE! > Could you explain what the patch fixes and why it works (would also > begreat to have that information in the commit-message)?I checked our > bugzilla and the community forum, but could not find anyrecent issue > regarding gluster and containers (I probably overlooked it). > AFAICT the patch disables running syncfs(2) on the gluster fuse-mount > usedfor containers. Does the syncfs call fail? What error do you > get?The syncfs call is there to ensure that the backup is consistent > as far aspossible - so I would not disable it without rationale. > On another note - we would need a signed CLA from you, in order to be > ableto include your code in our codebase - see [0]. > Best Regards,stoiko > [0] > https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright > > On Thu, 12 Nov 2020 19:48:38 +0100Thomas Legay wrote: > > Thomas Legay (1): Allow LXC snapshot backup with glusterfs mount > > point > > src/PVE/LXC.pm | 1 + 1 file changed, 1 insertion(+)