From: Jonas Theisen <j.theisen@proxmox.com>
To: "crandler@crandland.de" <crandler@crandland.de>
Cc: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [PATCH manager/qemu-server 00/15] check the target node's CPU before live migrating a VM
Date: Fri, 20 Nov 2026 15:53:19 +0100 [thread overview]
Message-ID: <cc7fce7a-37ff-416c-a97b-8236e53061db@proxmox.com> (raw)
In-Reply-To: <38B8F285-72BD-CA4C-AC77-1FB069EF64DE@hxcore.ol>
Thank you for the feedback!
Comments inline:
On 11/20/26 01:23, crandler@crandland.de wrote:
> <snip>
>
> 1. Built-in models are not covered. A VM with 'x86-64-v3' that is live
> migrated to a node without AVX2 still fails only when QEMU starts on
> the target ("QEMU exited with code 1"). The target builds the CPU
> again from the config, but the model flags are the same, and
> 'enforce' is set for all models except 'host'. Since the x86-64-v*
> flags show up explicitly in the running QEMU CPU, the flag part of
> the 'kept-cpu-flags' check should work for them as well. The
> migration dialog would then mark such a node as incompatible, and
> 'migrateall' would skip these VMs.
Completely correct and an overlook on my end. I have added / extended
the appropriate check and will include that in v2.
Thanks for noticing!
>
> 2. HA node selection. As far as I can see, the checks also apply to
> migrations started by the HA stack, which is great. The HA manager
> does not know about them when it picks a target, though (maintenance
> mode, auto-rebalance). If it picks a node that cannot run the VM's
> CPU, the migration is refused and the service goes back to 'started'
> on the source without the failure being recorded, so a later round
> can pick the same node again. #8059 describes this for auto-rebalance
> (failed migrations are retried, candidates are not checked for
> migratability). Would it make sense to let the CRM filter its
> candidate nodes with the same check, or should I open a separate bug
> for that?
I think this could be covered in the bug you already mentioned.
I included a pointer to it in the v2 cover letter but maybe a small comment
on the existing bug could help clarify the interconnect of both issues.
>
> Thanks,
> Sven
>
next parent reply other threads:[~2026-11-20 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <38B8F285-72BD-CA4C-AC77-1FB069EF64DE@hxcore.ol>
2026-11-20 14:53 ` Jonas Theisen [this message]
2026-11-18 15:40 [PATCH manager/qemu-server 00/15] check the target node's CPU before live migrating a VM Jonas Theisen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc7fce7a-37ff-416c-a97b-8236e53061db@proxmox.com \
--to=j.theisen@proxmox.com \
--cc=crandler@crandland.de \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.