From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <l.wagner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 970FD92470 for <pbs-devel@lists.proxmox.com>; Tue, 14 Mar 2023 09:36:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6F51C1D467 for <pbs-devel@lists.proxmox.com>; Tue, 14 Mar 2023 09:35:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Tue, 14 Mar 2023 09:35:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 632C2446E1 for <pbs-devel@lists.proxmox.com>; Tue, 14 Mar 2023 09:35:56 +0100 (CET) Message-ID: <cbcf96b2-b68e-733f-1401-bb25370120f2@proxmox.com> Date: Tue, 14 Mar 2023 09:35:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: pbs-devel@lists.proxmox.com References: <20230213143104.905246-1-l.wagner@proxmox.com> From: Lukas Wagner <l.wagner@proxmox.com> In-Reply-To: <20230213143104.905246-1-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.156 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup] realm sync: show warnings if attributes do not meet their constraints X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 14 Mar 2023 08:36:27 -0000 On 2/13/23 15:31, Lukas Wagner wrote: > Previously, if the value of a synced property did not validate properly > (e.g only 1 character in length instead of the required 2), the whole > sync job failed without any useful error message. > > In this commit, the values are validated manually by their > respective StringSchema. If the validation fails, the value is > ignored and a warning is displayed in the task log. > > In addition to that, some error messages have been improved. > Also, user sync is now more fault-tolerant in general, showing > warnings if something goes wrong while creating/updating a > single user, instead of aborting the whole sync job. > > Reported-by: Friedrich Weber <f.weber@proxmox.com> > Signed-off-by: Lukas Wagner <l.wagner@proxmox.com> Ping. Would be nice to get this in for the next release, as it improves the behavior for the already merged user sync code. There are two more smallish follow-up patches [1, 2] on the list which I won't ping separately, since they are only cleanup. [1] https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005940.html [2] https://lists.proxmox.com/pipermail/pbs-devel/2023-February/005939.html -- - Lukas