From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id B3A691FF0DE for ; Thu, 19 Nov 2026 15:15:38 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 44FCC21842; Thu, 19 Nov 2026 15:14:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=genua.de; s=202307; t=1795097659; bh=eFkK0s/9IT0xQNcYSamu+nadFnYFNvi5VtwIucg2Fos=; h=Date:From:To:Subject:References:In-Reply-To:From; b=hm5XtlNZASUQiKwEZKx1F+YGhL+rbUdVna0HWryIDIJl4/K33vWCaKmR4yc7taH48 FQ45FAmU/HdAD2fQ9pWkBk+YGrbo+qnb5J1VcUOqcB2Y+F/RjfIEcoamfIEgFMT1UP aFDKbsXWzahpq1RXuznTyGE9iI92vvG5pnghc/fpufWIMXdbgTp1iJrBoQqTq7ArOD Tq1oWuA5nxhkopRS0OxafFOt9XqIaLt9qXlfJJWGQOJPXZmEAZHN+YyOLHgO+R6It0 tAD32Yjrm37i5Jo9+pmM/sigFJ7bUGP9CrQCFELodmMKQTlseiCa/YZEml+CvrZFkL 1KWG5KEFznQFQ== Date: Thu, 19 Nov 2026 15:14:18 +0100 From: Christian Ludwig To: Subject: [PATCH pve-storage v4 09/20] test: cover efi-firmware volumes in parse_volname and path_to_volume_id Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [192.168.217.185] X-ClientProxiedBy: kch1-mta07.win.genua.de (10.208.16.107) To kch1-mta07.win.genua.de (10.208.16.107) Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline X-SPAM-LEVEL: Spam detection results: 0 AWL 0.056 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record UNPARSEABLE_RELAY 0.001 Informational: message has unparseable relay lines Message-ID-Hash: APENKBFRXDNRBWN75Q4S7Y4NJ6LF2QVU X-Message-ID-Hash: APENKBFRXDNRBWN75Q4S7Y4NJ6LF2QVU X-MailFrom: christian_ludwig@genua.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Check that only names with the safe character class and the '.fd' extension are recognized as efi-firmware volumes. Reviewed-by: Fiona Ebner Signed-off-by: Christian Ludwig --- src/test/parse_volname_test.pm | 18 ++++++++++++++++++ src/test/path_to_volume_id_test.pm | 13 +++++++++++++ 2 files changed, 31 insertions(+) diff --git a/src/test/parse_volname_test.pm b/src/test/parse_volname_test.pm index b8a4a21..9492d87 100644 --- a/src/test/parse_volname_test.pm +++ b/src/test/parse_volname_test.pm @@ -252,6 +252,24 @@ my $tests = [ volname => "import/test.foo", expected => "unable to parse directory volume name 'import/test.foo'\n", }, + { + description => 'Failed match: EFI firmware, wrong extension', + volname => 'efi-firmware/custom-ovmf-code.raw', + expected => + "unable to parse directory volume name 'efi-firmware/custom-ovmf-code.raw'\n", + }, + { + description => 'Failed match: EFI firmware, upper case extension', + volname => 'efi-firmware/custom-ovmf-code.FD', + expected => + "unable to parse directory volume name 'efi-firmware/custom-ovmf-code.FD'\n", + }, + { + description => 'Failed match: EFI firmware, unsafe characters', + volname => 'efi-firmware/custom ovmf code.fd', + expected => + "unable to parse directory volume name 'efi-firmware/custom ovmf code.fd'\n", + }, ]; # create more test cases for VM disk images matches diff --git a/src/test/path_to_volume_id_test.pm b/src/test/path_to_volume_id_test.pm index ff162b1..d121e3d 100644 --- a/src/test/path_to_volume_id_test.pm +++ b/src/test/path_to_volume_id_test.pm @@ -29,6 +29,7 @@ my $scfg = { 'iso' => 1, 'backup' => 1, 'vztmpl' => 1, + 'efi-firmware' => 1, }, }, }, @@ -185,6 +186,13 @@ my @tests = ( 'import', 'local:import/import.ovf', ], }, + { + description => 'EFI firmware, fd', + volname => "$storage_dir/efi-firmware/custom-ovmf-code.fd", + expected => [ + 'efi-firmware', 'local:efi-firmware/custom-ovmf-code.fd', + ], + }, # no matches, path or files with failures { @@ -232,6 +240,11 @@ my @tests = ( volname => "$storage_dir/import/test.foo", expected => [''], }, + { + description => 'EFI firmware, wrong extension', + volname => "$storage_dir/efi-firmware/custom-ovmf-code.raw", + expected => [''], + }, ); plan tests => scalar @tests + 1; -- 2.34.1