From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <l.wagner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 01BCD61CE2; Wed, 26 Jul 2023 15:45:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D5CD37BFC; Wed, 26 Jul 2023 15:45:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Wed, 26 Jul 2023 15:45:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3B76745974; Wed, 26 Jul 2023 15:45:03 +0200 (CEST) Message-ID: <cadb8d62-e721-d1e7-adce-0035e8a770d9@proxmox.com> Date: Wed, 26 Jul 2023 15:45:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Wolfgang Bumiller <w.bumiller@proxmox.com> Cc: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com References: <20230726125006.616124-1-l.wagner@proxmox.com> <20230726125006.616124-3-l.wagner@proxmox.com> <f4jzy7nv2dmovwlcdjebzrud3tece5xbjsiafhkeqcnyv2p7a3@fr4rdwfqu5uy> From: Lukas Wagner <l.wagner@proxmox.com> In-Reply-To: <f4jzy7nv2dmovwlcdjebzrud3tece5xbjsiafhkeqcnyv2p7a3@fr4rdwfqu5uy> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [pbs-devel] [PATCH proxmox 2/5] router: rest-server: auth-api: use new http-error crate X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 26 Jul 2023 13:45:04 -0000 On 7/26/23 15:41, Wolfgang Bumiller wrote: > I'd like `proxmox-router` to keep re-exporting both the `http_bail/err` > macros and the `HttpError` type. This would require much fewer changes > at all the call sites, and we don't need to explicitly depend on the new > crate everywhere. Its point is mostly that perlmod code doesn't need to > pull the router into our perl code base. Alright, I'll send a v2 with the things re-exported. Thanks! -- - Lukas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <l.wagner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 01BCD61CE2; Wed, 26 Jul 2023 15:45:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D5CD37BFC; Wed, 26 Jul 2023 15:45:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS; Wed, 26 Jul 2023 15:45:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3B76745974; Wed, 26 Jul 2023 15:45:03 +0200 (CEST) Message-ID: <cadb8d62-e721-d1e7-adce-0035e8a770d9@proxmox.com> Date: Wed, 26 Jul 2023 15:45:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Wolfgang Bumiller <w.bumiller@proxmox.com> Cc: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com References: <20230726125006.616124-1-l.wagner@proxmox.com> <20230726125006.616124-3-l.wagner@proxmox.com> <f4jzy7nv2dmovwlcdjebzrud3tece5xbjsiafhkeqcnyv2p7a3@fr4rdwfqu5uy> From: Lukas Wagner <l.wagner@proxmox.com> In-Reply-To: <f4jzy7nv2dmovwlcdjebzrud3tece5xbjsiafhkeqcnyv2p7a3@fr4rdwfqu5uy> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox 2/5] router: rest-server: auth-api: use new http-error crate X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 26 Jul 2023 13:45:04 -0000 On 7/26/23 15:41, Wolfgang Bumiller wrote: > I'd like `proxmox-router` to keep re-exporting both the `http_bail/err` > macros and the `HttpError` type. This would require much fewer changes > at all the call sites, and we don't need to explicitly depend on the new > crate everywhere. Its point is mostly that perlmod code doesn't need to > pull the router into our perl code base. Alright, I'll send a v2 with the things re-exported. Thanks! -- - Lukas