From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 91ECD1FF138 for ; Tue, 21 Jul 2026 14:50:54 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 6D8C72146B; Tue, 21 Jul 2026 14:50:54 +0200 (CEST) Message-ID: Date: Tue, 21 Jul 2026 14:50:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH widget-toolkit] fix #7721: fix zoom interaction on charts with no initial store To: Dominik Csapak , pbs-devel@lists.proxmox.com References: <20260617125812.3418396-1-d.csapak@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260617125812.3418396-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784638224957 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.191 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) NUMERIC_HTTP_ADDR 0.001 Uses a numeric IP address in URL RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record WEIRD_PORT 0.001 Uses non-standard port number for HTTP Message-ID-Hash: DF73I5LVY2FWYSJDA3IOS6MNGSPKCNLJ X-Message-ID-Hash: DF73I5LVY2FWYSJDA3IOS6MNGSPKCNLJ X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 6/17/26 2:57 PM, Dominik Csapak wrote: > In our current ExtJs version (7.0), having animations disabled on charts > breaks the zoom interaction. One can zoom in and out once, but never > again. > > We generally keep animations enabled on our proxmoxRRDChart, but only > after the store's first load, to avoid animating from the empty store to > the initial data. This happens in initComponent on the store that was > given during instantiation. > > In some cases, however (e.g. the PBS datastore summary panel), the chart > has no initial store and instead gets one via 'setStore'. Here, the > event of the old (non-existent) store was never fired, so animations > were never activated and the zoom interaction was buggy. > > Fix this by overriding `setStore` to install an event handler for the > new store that enables the animations. If this runs more than once, it > would just set the animation value to the same again, which is fine. > > Signed-off-by: Dominik Csapak > --- Checked this fixes the zoom issue on the datastore summary panels and that they are animated. Other RRD charts (e.g. in PVE) are unaffected. This however breaks rendering of the panel when switching back and fort between 2 datastores for me, not being an issue with the un-patched widget toolkit, console logs: ``` Uncaught (in promise) Error: undefined ExtJS 55 ext-all.js:22:31982 Uncaught (in promise) Error: undefined ExtJS 55 ext-all.js:22:31982 Uncaught TypeError: can't access property "unmask", me.down(...) is null initComponent https://172.16.0.18:8007/js/proxmox-backup-gui.js:14631 ExtJS 7 onProxyLoad https://172.16.0.18:8007/widgettoolkit/proxmoxlib.js:1785 ExtJS 25 run_load_task https://172.16.0.18:8007/widgettoolkit/proxmoxlib.js:3697 ExtJS 5 run_load_task https://172.16.0.18:8007/widgettoolkit/proxmoxlib.js:3700 ExtJS 25 run_load_task https://172.16.0.18:8007/widgettoolkit/proxmoxlib.js:3697 h ExtJS proxmox-backup-gui.js:14631:16 Uncaught TypeError: can't access property "unmask", me.down(...) is null initComponent https://172.16.0.18:8007/js/proxmox-backup-gui.js:14631 ExtJS 7 onProxyLoad https://172.16.0.18:8007/widgettoolkit/proxmoxlib.js:1785 ExtJS 25 run_load_task https://172.16.0.18:8007/widgettoolkit/proxmoxlib.js:3697 ExtJS 5 run_load_task https://172.16.0.18:8007/widgettoolkit/proxmoxlib.js:3700 ExtJS 25 run_load_task https://172.16.0.18:8007/widgettoolkit/proxmoxlib.js:3697 h ExtJS proxmox-backup-gui.js:14631:16 ``` I do fail to see however how this patch might be related to the `pbsDataStoreInfo` there?