Re: [pve-devel] [PATCH manager v3 1/2] ui: resource tree: use 'diskuse' instead of calculating everytime

[Jonas Theisen <j.theisen@proxmox.com>]

On 9/9/26 11:29, Dominik Csapak wrote:
> On 9/9/26 11:22 AM, Jonas Theisen wrote:
>> On 1/23/26 09:12, Dominik Csapak wrote:
>>> the resource store has a field 'diskuse' which it calculates on update.
>>> Use that instead of calculating the value ourselves everytime.
>>>
>>> For change detection, we only need a resolution of 0.01 (since we want
>>> to use the percentage as integer) so check that the difference of 
>>> old and new
>>> is bigger than 0.9% .
>>>
>>> This works because we only overwrite the values in the treestore if
>>> anything changed, so multiple small changes to the diskuse will not be
>>> lost.
>>>
>>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>>> ---
>>> <snip>
>>
>> Applied and tested the patch on top of current pve-manager 9.2.18
>> Tested VM state changes and storage usage changes on a single node
>>
>> Problem: The tooltip style usage shown when hovering over a storage
>> reports the usage with two decimal places so per mille.
>> Due to the update logic only triggering on changes of 1% or greater,
>> a change smaller than that will cause the tooltip to get out of sync
>> from the actual usage reported by the status page.
>>
>
> thanks for checking!
>
> Ok so I think lowering the threshold to 0.01% difference probably
> does not have the effect I'd hoped for (i.e. not refreshing too often)
>
> So I'd either render the tooltip as whole percentage too, or
> use 0.1% in both cases as a middle ground.
>
> What do you think?

My personal preference would be to render the tooltip as
rounded percentage since in my head it is just a quick view option.
If the user wants the exact number, they can look into the status page.
>
>> -- 
>> Tested-by: Jonas Theisen <j.theisen@proxmox.com>
>