From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id DFE521FF0B7 for ; Fri, 13 Nov 2026 13:52:33 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E84B12184B; Fri, 13 Nov 2026 13:52:06 +0100 (CET) Message-ID: Date: Fri, 13 Nov 2026 13:51:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH guest-common v7 02/32] abstract migrate: declare fork_tunnel() as an abstract method To: =?UTF-8?Q?Michael_K=C3=B6ppl?= , pve-devel@lists.proxmox.com References: <20261112115001.107306-1-f.ebner@proxmox.com> <20261112115001.107306-3-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794574310763 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.255 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MOERHX5KXMUAKKHXHOJAJPB2LPC2Z3XP X-Message-ID-Hash: MOERHX5KXMUAKKHXHOJAJPB2LPC2Z3XP X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 13.11.26 um 1:46 PM schrieb Michael Köppl: > Reviewed-by: Michael Köppl > > On Thu Nov 12, 2026 at 12:48 PM CET, Fiona Ebner wrote: >> To be used in a common check_config_on_target() method. > > nit: this is `prepare_local_cluster_checks()`, no? Yes, I hadn't thought about grouping with the SSH check yet when I wrote this ^^