From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6423860F55 for <pbs-devel@lists.proxmox.com>; Thu, 3 Feb 2022 14:37:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5B0E327685 for <pbs-devel@lists.proxmox.com>; Thu, 3 Feb 2022 14:37:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DB8722767A for <pbs-devel@lists.proxmox.com>; Thu, 3 Feb 2022 14:37:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A8C5B45E17 for <pbs-devel@lists.proxmox.com>; Thu, 3 Feb 2022 14:37:28 +0100 (CET) Message-ID: <c9e59bcf-2b70-b9a9-d4ef-ed89df7dee0f@proxmox.com> Date: Thu, 3 Feb 2022 14:37:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Matthias Heiserer <m.heiserer@proxmox.com> References: <20220124100950.2752861-1-m.heiserer@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20220124100950.2752861-1-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-proxy.rs, node.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup v2] fix #3103. node config: allow to configure default UI language X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 03 Feb 2022 13:37:29 -0000 On 24.01.22 11:09, Matthias Heiserer wrote: > This language is only used if none is set in the cookies. > > Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com> > --- > Changes from v1: > Adhere to max length > Remove trailing whitespace > Use enum to store available translations > Add language name to enum variants > Rename chinese and portugese to same case as in i18 files > Check for existance of translation file when using default language > > src/bin/proxmox-backup-proxy.rs | 9 ++++ > src/config/node.rs | 75 ++++++++++++++++++++++++++++++++- > 2 files changed, 82 insertions(+), 2 deletions(-) > > applied, thanks! I dropped the need for `#[allow(non_camel_case_types)]` on the enu, as we have a serde-rename on the affected members anyway, also cleaned up how the proxy extracts the language stuff, as that was quite convoluted.. FYI, there's still something missing: the api is missing integration for this in the node config update method, so setting it via API or via `proxmox-backup-manager node update --default-language it` cannot work yet, fixing that is quite trivial, can you please send a followup patch for that and ideally also the GUI support?