From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9CE031FF15C for ; Wed, 19 Feb 2025 10:32:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 340901BC94; Wed, 19 Feb 2025 10:32:15 +0100 (CET) Message-ID: Date: Wed, 19 Feb 2025 10:31:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: Proxmox VE development discussion , Maximiliano Sandoval References: <20250218162844.476120-1-m.sandoval@proxmox.com> Content-Language: en-US In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL -0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage v2 1/2] fix #3873: btrfs: check for correct subvolume taking snapshot X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 19.02.25 um 10:24 schrieb Fiona Ebner: > Am 18.02.25 um 17:28 schrieb Maximiliano Sandoval: >> +# Calls `$code->($volume, $snap_name)` for each snapshot of the subvolume. >> +my sub foreach_snapshot_of_subvol : prototype($$) { > > We can just rename foreach_subvol() and the $BTRFS_VOL_REGEX instead of > adding this new wrapper. As already written in the review of v1, the > regex requires a snapshot to be present. This means the regex is a > misnomer and the foreach_subvol() helper already operates only on > snapshots and can also be renamed. It'd be more concise/straightforward > and otherwise, those remain confusing. > I mean, it still makes sense to have the helper only operate on the snapshots of a given subvolume, because both the existing user in free_image() and your new user want that. >> + my ($subvol, $code) = @_; >> + >> + my $basename = basename($subvol); >> + my $dir = dirname($subvol); >> + foreach_subvol($dir, sub { >> + my ($volume, $name, $snap) = @_; >> + return if $name ne $basename; >> + return if !defined $snap; >> + $code->($volume, $snap); >> + }); >> +} >> + >> sub free_image { >> my ($class, $storeid, $scfg, $volname, $isBase, $_format) = @_; >> _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel