all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>,
	Tiomet Pelston <tiometpelston@gmail.com>
Subject: Re: [pve-devel] [PATCH common 1/1] fix #5623: ovs other_config set to 0 not saved in network config
Date: Wed, 30 Oct 2024 09:53:31 +0100	[thread overview]
Message-ID: <c8d7619b-925e-43a2-92a1-f7abbd349877@proxmox.com> (raw)
In-Reply-To: <1e6d47f2-7d5c-4201-b235-5686dad0a9d5@proxmox.com>

Am 29/10/2024 um 16:29 schrieb Aaron Lauterer:
> Does what it says. Will check definedness and not truthyness. Therefore 
> values that would evaluate as falsy still end up in the config.
> 
> Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>
> Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>

Applied this patch with your review trailers, thanks to both of you!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-10-30  8:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20241023164849.3027-1-tiometpelston@gmail.com>
2024-10-23 16:48 ` Tiomet Pelston via pve-devel
2024-10-29 15:29   ` Aaron Lauterer
2024-10-30  8:53     ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8d7619b-925e-43a2-92a1-f7abbd349877@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=tiometpelston@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal