all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage/manager] guest import improvements
Date: Tue, 19 Mar 2024 18:18:16 +0100	[thread overview]
Message-ID: <c8991ba2-ff43-4dbf-81fc-3cd287fd705f@proxmox.com> (raw)
In-Reply-To: <20240319130032.2192847-1-d.csapak@proxmox.com>

On 19/03/2024 14:00, Dominik Csapak wrote:
> some sensible improvements for the guest import
> 
> pve-storage:
> 
> Dominik Csapak (2):
>   esxi: add warning for losing efi state
>   esxi: only add scsihw if it's defined
> 
>  src/PVE/Storage/ESXiPlugin.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> pve-manager:
> 
> Dominik Csapak (4):
>   ui: guest import: fix isWindows check
>   ui: guest import: auto activate virtio preparation for win + ovmf
>   ui: guest import: correctly set default scsihw value
>   ui: guest import: add warning for losing efi state
> 
>  www/manager6/window/GuestImport.js | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)
> 


applied now also the UI patches, thanks!

I squashed in a fix to a "extra whitespace in parenthesis" eslint warning
in patch 3/4 and split up the overly long line in 4/4.




      parent reply	other threads:[~2024-03-19 17:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19 13:00 [pve-devel] " Dominik Csapak
2024-03-19 13:00 ` [pve-devel] [PATCH storage 1/2] esxi: add warning for losing efi state Dominik Csapak
2024-03-19 17:12   ` [pve-devel] applied: " Thomas Lamprecht
2024-03-19 13:00 ` [pve-devel] [PATCH storage 2/2] esxi: only add scsihw if it's defined Dominik Csapak
2024-03-19 17:12   ` [pve-devel] applied: " Thomas Lamprecht
2024-03-19 13:00 ` [pve-devel] [PATCH manager 1/4] ui: guest import: fix isWindows check Dominik Csapak
2024-03-19 13:00 ` [pve-devel] [PATCH manager 2/4] ui: guest import: auto activate virtio preparation for win + ovmf Dominik Csapak
2024-03-19 13:00 ` [pve-devel] [PATCH manager 3/4] ui: guest import: correctly set default scsihw value Dominik Csapak
2024-03-19 13:00 ` [pve-devel] [PATCH manager 4/4] ui: guest import: add warning for losing efi state Dominik Csapak
2024-03-19 17:18 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8991ba2-ff43-4dbf-81fc-3cd287fd705f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal