all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ludwig <christian_ludwig@genua.de>
To: <pve-devel@lists.proxmox.com>
Subject: [PATCH qemu-server v4 12/20] api: check the custom firmware of the bios option
Date: Thu, 19 Nov 2026 15:14:23 +0100	[thread overview]
Message-ID: <c713a3e0e9d9e01143e65d102d800b0efbc645f0.1795092172.git.christian_ludwig@genua.de> (raw)
In-Reply-To: <cover.1795092172.git.christian_ludwig@genua.de>

When the bios option is set via the POST/PUT {vmid}/config endpoints,
check that the user may access the custom firmware image, that it is an
efi-firmware volume, and that the BIOS type is 'ovmf'. Like for ISO
images, whether the image is usable on the node is only checked when the
VM is started. The option keeps requiring the VM.Config.Options
permission.

A cloned VM references the same firmware image, like an ISO image, so a
clone is only considered shared if the image is on a shared storage.

Report custom firmware images in the local disks of the migration
precondition check, so that clients can tell why a migration is not
possible.

Signed-off-by: Christian Ludwig <christian_ludwig@genua.de>
---
 src/PVE/API2/Qemu.pm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index e0661738..943d606f 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -33,6 +33,7 @@ use PVE::GuestImport;
 use PVE::QemuConfig;
 use PVE::QemuServer;
 use PVE::QemuServer::Agent;
+use PVE::QemuServer::BIOS;
 use PVE::QemuServer::Blockdev;
 use PVE::QemuServer::BlockJob;
 use PVE::QemuServer::Cloudinit;
@@ -198,6 +199,18 @@ my $foreach_volume_with_alloc = sub {
     }
 };
 
+my sub check_bios_param {
+    my ($param) = @_;
+
+    return if !defined($param->{bios});
+
+    eval { PVE::QemuServer::BIOS::check_bios($param->{bios}) };
+    if (my $err = $@) {
+        chomp($err);
+        raise_param_exc({ bios => $err });
+    }
+}
+
 my $check_drive_param = sub {
     my ($param, $storecfg, $extra_checks) = @_;
 
@@ -383,6 +396,13 @@ my $check_storage_access = sub {
             );
         }
     }
+
+    my $firmware = PVE::QemuServer::BIOS::parse_bios($settings->{bios})->{firmware};
+    if (defined($firmware)) {
+        PVE::Storage::check_volume_access(
+            $rpcenv, $authuser, $storecfg, $vmid, $firmware, 'efi-firmware',
+        );
+    }
 };
 
 my $check_storage_access_clone = sub {
@@ -425,6 +445,13 @@ my $check_storage_access_clone = sub {
     $rpcenv->check($authuser, "/storage/$conf->{vmstatestorage}", ['Datastore.AllocateSpace'])
         if defined($conf->{vmstatestorage});
 
+    # like ISO images, a custom firmware image is simply referenced by the clone
+    if (my $firmware = PVE::QemuServer::BIOS::get_bios_firmware($conf)) {
+        my ($sid) = PVE::Storage::parse_volume_id($firmware);
+        my $scfg = PVE::Storage::storage_config($storecfg, $sid);
+        $sharedvm = 0 if !$scfg->{shared};
+    }
+
     return $sharedvm;
 };
 
@@ -1499,6 +1526,7 @@ __PACKAGE__->register_method({
             &$check_cpu_model_access($rpcenv, $authuser, $param);
 
             $check_drive_param->($param, $storecfg);
+            check_bios_param($param);
 
             PVE::QemuServer::Network::add_random_macs($param);
         }
@@ -2339,6 +2367,8 @@ my $update_vm_api = sub {
         $rpcenv, $authuser, $storecfg, $vmid, $param, undef, $extraction_storage,
     );
 
+    check_bios_param($param);
+
     PVE::QemuServer::check_bridge_access($rpcenv, $authuser, $param);
 
     my $load_and_check_config = sub {
@@ -5551,6 +5581,11 @@ __PACKAGE__->register_method({
                             type => 'boolean',
                             description => 'True if the disk is a cdrom.',
                         },
+                        is_firmware => {
+                            type => 'boolean',
+                            description => 'True if the volume is a custom firmware image.',
+                            optional => 1,
+                        },
                         is_unused => {
                             type => 'boolean',
                             description => 'True if the disk is unused.',
-- 
2.34.1




  parent reply	other threads:[~2026-11-19 14:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 14:14 [PATCH v4 00/20] Support for custom EFI firmware Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 01/20] plugin: add efi-firmware content type Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 02/20] test: get_subdir: cover the " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 03/20] plugins: allow the efi-firmware content type on file based storages Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 04/20] plugin: allow overriding the efi-firmware directory Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 05/20] plugin: support efi-firmware volumes in volume export and import Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 06/20] api: status: support efi-firmware in upload and download-url Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 07/20] test: volume access: cover efi-firmware volumes Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 08/20] test: list volumes: " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-storage v4 09/20] test: cover efi-firmware volumes in parse_volname and path_to_volume_id Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 10/20] config: define bios schema as property-string Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 11/20] bios: add a custom firmware sub-property Christian Ludwig
2026-11-19 14:14 ` Christian Ludwig [this message]
2026-11-19 14:14 ` [PATCH qemu-server v4 13/20] test: custom firmware in the bios option Christian Ludwig
2026-11-19 14:14 ` [PATCH qemu-server v4 14/20] test: custom firmware volumes in replication and migration Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 15/20] ui: storage: add efi-firmware content type support Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 16/20] ui: form: support other content types in the ISO selector Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 17/20] ui: qemu: allow selecting a custom EFI firmware image Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-manager v4 18/20] ui: migrate: refuse migration with a local custom " Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-docs v4 19/20] pvesm: document the efi-firmware content type Christian Ludwig
2026-11-19 14:14 ` [PATCH pve-docs v4 20/20] qm: document the custom firmware of the bios option Christian Ludwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c713a3e0e9d9e01143e65d102d800b0efbc645f0.1795092172.git.christian_ludwig@genua.de \
    --to=christian_ludwig@genua.de \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal