From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2A62A69000 for <pve-devel@pve.proxmox.com>; Fri, 28 Aug 2020 15:09:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1FE9D226C7 for <pve-devel@pve.proxmox.com>; Fri, 28 Aug 2020 15:09:33 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4F1F7226B9 for <pve-devel@pve.proxmox.com>; Fri, 28 Aug 2020 15:09:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 13BEE4490F for <pve-devel@pve.proxmox.com>; Fri, 28 Aug 2020 15:09:32 +0200 (CEST) To: Alexandre DERUMIER <aderumier@odiso.com> Cc: pve-devel <pve-devel@pve.proxmox.com> References: <20200827111655.22957-1-f.ebner@proxmox.com> <110ea3a0-4076-96fa-b31b-aca0188ed2bb@proxmox.com> <1844854487.155436.1598619062646.JavaMail.zimbra@odiso.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <c6846219-0a04-ff6d-cdd4-57e34460647f@proxmox.com> Date: Fri, 28 Aug 2020 15:09:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Thunderbird/80.0 MIME-Version: 1.0 In-Reply-To: <1844854487.155436.1598619062646.JavaMail.zimbra@odiso.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.774 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.782 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] sdn patches ready for review X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 28 Aug 2020 13:09:33 -0000 Hi, On 8/28/20 2:51 PM, Alexandre DERUMIER wrote: > Hi everybody, > > I think my summer work on sdn is ready for review. > I have implemented subnet/nat/ipam/dns registration. cool! > > I'll stop to add new feature for now, I have planned time in september for fixes,cleanup. Ok, thanks for the information! I'll allocate a few hours next week to give initial feedback. I already skimmed each iteration of your patches shallowly, nothing made any alarm bells ring, so from what I can tell now, it should head in the right directions. The features are definitively nice and I think many PVE users would like to have them quite a bit. > Here the different patch series: > > > [pve-devel] [PATCH v7 pve-network 00/21] sdn : add subnets management > https://lists.proxmox.com/pipermail/pve-devel/2020-August/044850.html > > [pve-devel] [PATCH v4 pve-manager 0/8] sdn : add subnets management > https://lists.proxmox.com/pipermail/pve-devel/2020-August/044775.html > > > [pve-devel] [PATCH v4 pve-cluster 0/4] sdn : add subnets management > https://lists.proxmox.com/pipermail/pve-devel/2020-August/044770.html > > [pve-devel] [PATCH v2 pve-docs 0/2] simple zone + subnet/ipam documentation > https://lists.proxmox.com/pipermail/pve-devel/2020-August/044874.html > > > For testing subnet/ipam in lxc (is really a poc, do not apply) -> > > [pve-devel] [PATCH v2 pve-container] POC : add/del/update ip from vnet-subnet-ipam > https://lists.proxmox.com/pipermail/pve-devel/2020-August/044781.html > > Currently, if you use a vnet with subnet with registered ipam, and you keep the ip field empty, it'll auto-assign an ip. > (or you can still defined your own ip, it'll be registered in pam too) > > OK. Do you already use this new stuff somewhere in your setups?