From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0BB051FF13B for ; Wed, 25 Feb 2026 10:23:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1DD40315D7; Wed, 25 Feb 2026 10:24:03 +0100 (CET) Message-ID: Date: Wed, 25 Feb 2026 10:23:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-ve-rs 9/9] frr: store frr template content as a const map To: pve-devel@lists.proxmox.com References: <20260203160246.353351-1-g.goller@proxmox.com> <20260203160246.353351-10-g.goller@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20260203160246.353351-10-g.goller@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.342 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.113 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.358 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.659 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VGOZ2ZUGJPM5PDWPIZ5LWEVJMVOF22GF X-Message-ID-Hash: VGOZ2ZUGJPM5PDWPIZ5LWEVJMVOF22GF X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Could this be done in patch 5/9 already, with changing the patches afterwards accordingly? On 2/3/26 5:02 PM, Gabriel Goller wrote: > We need to retrieve the template content from pve-network (for the > pvesdn cli), so we need to make these public. Use the `phf` crate to > store them in a const map. > > Signed-off-by: Gabriel Goller > --- > proxmox-frr/Cargo.toml | 1 + > proxmox-frr/debian/control | 4 +++ > proxmox-frr/src/ser/serializer.rs | 56 +++++++++---------------------- > 3 files changed, 21 insertions(+), 40 deletions(-) > > diff --git a/proxmox-frr/Cargo.toml b/proxmox-frr/Cargo.toml > index 560a04b42980..173d8dfc8924 100644 > --- a/proxmox-frr/Cargo.toml > +++ b/proxmox-frr/Cargo.toml > @@ -17,6 +17,7 @@ serde = { workspace = true, features = [ "derive" ] } > serde_repr = "0.1" > minijinja = { version = "2.5", features = [ "multi_template", "loader" ] } > bon = "3.7" > +phf = { version = "0.11.2", features = ["macros"] } > > proxmox-network-types = { workspace = true } > proxmox-sdn-types = { workspace = true } > diff --git a/proxmox-frr/debian/control b/proxmox-frr/debian/control > index 10651e640ba3..fb0960c4c75d 100644 > --- a/proxmox-frr/debian/control > +++ b/proxmox-frr/debian/control > @@ -11,6 +11,8 @@ Build-Depends-Arch: cargo:native , > librust-minijinja-2+default-dev (>= 2.5-~~) , > librust-minijinja-2+loader-dev (>= 2.5-~~) , > librust-minijinja-2+multi-template-dev (>= 2.5-~~) , > + librust-phf-0.11+default-dev (>= 0.11.2-~~) , > + librust-phf-0.11+macros-dev (>= 0.11.2-~~) , > librust-proxmox-network-types-0.1+default-dev (>= 0.1.1-~~) , > librust-proxmox-sdn-types-0.1+default-dev , > librust-proxmox-serde-1+default-dev , > @@ -36,6 +38,8 @@ Depends: > librust-minijinja-2+default-dev (>= 2.5-~~), > librust-minijinja-2+loader-dev (>= 2.5-~~), > librust-minijinja-2+multi-template-dev (>= 2.5-~~), > + librust-phf-0.11+default-dev (>= 0.11.2-~~), > + librust-phf-0.11+macros-dev (>= 0.11.2-~~), > librust-proxmox-network-types-0.1+default-dev (>= 0.1.1-~~), > librust-proxmox-sdn-types-0.1+default-dev, > librust-proxmox-serde-1+default-dev, > diff --git a/proxmox-frr/src/ser/serializer.rs b/proxmox-frr/src/ser/serializer.rs > index 12e4190744eb..67cc36562e9b 100644 > --- a/proxmox-frr/src/ser/serializer.rs > +++ b/proxmox-frr/src/ser/serializer.rs > @@ -5,6 +5,21 @@ use minijinja::Environment; > > use crate::ser::FrrConfig; > > +pub static TEMPLATES: phf::Map<&'static str, &'static str> = phf::phf_map! { > + "fabricd.jinja" => include_str!("/usr/share/proxmox-frr/templates/fabricd.jinja"), > + "bgpd.jinja" => include_str!("/usr/share/proxmox-frr/templates/bgpd.jinja"), > + "isisd.jinja" => include_str!("/usr/share/proxmox-frr/templates/isisd.jinja"), > + "ospfd.jinja" => include_str!("/usr/share/proxmox-frr/templates/ospfd.jinja"), > + "bgp_router.jinja" => include_str!("/usr/share/proxmox-frr/templates/bgp_router.jinja"), > + "interface.jinja" => include_str!("/usr/share/proxmox-frr/templates/interface.jinja"), > + "access_lists.jinja" => include_str!("/usr/share/proxmox-frr/templates/access_lists.jinja"), > + "prefix_lists.jinja" => include_str!("/usr/share/proxmox-frr/templates/prefix_lists.jinja"), > + "route_maps.jinja" => include_str!("/usr/share/proxmox-frr/templates/route_maps.jinja"), > + "ip_routes.jinja" => include_str!("/usr/share/proxmox-frr/templates/ip_routes.jinja"), > + "protocol_routemaps.jinja" => include_str!("/usr/share/proxmox-frr/templates/protocol_routemaps.jinja"), > + "frr.conf.jinja" => include_str!("/usr/share/proxmox-frr/templates/frr.conf.jinja"), > +}; > + > fn create_env<'a>() -> Environment<'a> { > let mut env = Environment::new(); > > @@ -18,46 +33,7 @@ fn create_env<'a>() -> Environment<'a> { > match fs::read_to_string(override_path) { > Ok(template_content) => Ok(Some(template_content)), > // if that fails, read the vendored template: > - Err(_) => match name { > - "fabricd.jinja" => Ok(Some( > - include_str!("/usr/share/proxmox-frr/templates/fabricd.jinja").to_owned(), > - )), > - "bgpd.jinja" => Ok(Some( > - include_str!("/usr/share/proxmox-frr/templates/bgpd.jinja").to_owned(), > - )), > - "isisd.jinja" => Ok(Some( > - include_str!("/usr/share/proxmox-frr/templates/isisd.jinja").to_owned(), > - )), > - "ospfd.jinja" => Ok(Some( > - include_str!("/usr/share/proxmox-frr/templates/ospfd.jinja").to_owned(), > - )), > - "bgp_router.jinja" => Ok(Some( > - include_str!("/usr/share/proxmox-frr/templates/bgp_router.jinja").to_owned(), > - )), > - "interface.jinja" => Ok(Some( > - include_str!("/usr/share/proxmox-frr/templates/interface.jinja").to_owned(), > - )), > - "access_lists.jinja" => Ok(Some( > - include_str!("/usr/share/proxmox-frr/templates/access_lists.jinja").to_owned(), > - )), > - "prefix_lists.jinja" => Ok(Some( > - include_str!("/usr/share/proxmox-frr/templates/prefix_lists.jinja").to_owned(), > - )), > - "route_maps.jinja" => Ok(Some( > - include_str!("/usr/share/proxmox-frr/templates/route_maps.jinja").to_owned(), > - )), > - "ip_routes.jinja" => Ok(Some( > - include_str!("/usr/share/proxmox-frr/templates/ip_routes.jinja").to_owned(), > - )), > - "protocol_routemaps.jinja" => Ok(Some( > - include_str!("/usr/share/proxmox-frr/templates/protocol_routemaps.jinja") > - .to_owned(), > - )), > - "frr.conf.jinja" => Ok(Some( > - include_str!("/usr/share/proxmox-frr/templates/frr.conf.jinja").to_owned(), > - )), > - _ => Ok(None), > - }, > + Err(_) => Ok(TEMPLATES.get(name).map(|template| (*template).to_owned())), > } > }); >