From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 916CB1FF187 for ; Mon, 22 Sep 2025 19:16:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9E8DB20F3A; Mon, 22 Sep 2025 19:17:07 +0200 (CEST) Message-ID: Date: Mon, 22 Sep 2025 19:16:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , n.frey@proxmox.com References: <20250919093915.21641-1-n.frey@proxmox.com> <20250919093915.21641-5-n.frey@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20250919093915.21641-5-n.frey@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758561381719 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve-manager 4/5] api: add service state return schema X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 19.09.25 um 11:40 schrieb n.frey@proxmox.com: > From: Nicolas Frey > > Signed-off-by: Nicolas Frey > --- > PVE/API2/Services.pm | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/PVE/API2/Services.pm b/PVE/API2/Services.pm > index 708b6613..c8e3e933 100644 > --- a/PVE/API2/Services.pm > +++ b/PVE/API2/Services.pm > @@ -241,7 +241,35 @@ __PACKAGE__->register_method({ > }, > returns => { > type => "object", > - properties => {}, > + properties => { > + 'active-state' => { > + type => 'string', > + enum => ['active', 'inactive', 'unknown'], This is taken 1:1 from systemd's ActiveState of a unit. You can check the systemd.directives manual page for all known configuration and most state terms that systemd knows about. For "ActiveState" it links to the manual page describing the D-Bus interface of systemd, which has a table with all known values [1] that has a few more variants than what you include above. [0]: https://manpages.debian.org/trixie/systemd/systemd.directives.7.en.html [1]: https://manpages.debian.org/trixie/systemd/org.freedesktop.systemd1.5.en.html#:~:text=Unit%20ACTIVE%20states > + description => 'Current active state of the service process.', > + }, > + 'state' => { > + type => 'string', > + enum => ['running', 'dead', 'unknown'], Similar to above this can be a few other variants as well, you can check our code and then [1] to see what values this can actually include. > + description => 'Execution status of the service.', > + }, > + 'unit-state' => { > + type => 'string', > + enum => ['enabled', 'disabled', 'not-found'], There are a few additional variants here too, see [1] again, "UnitFileState" is documented quite close to the "ActiveState" > + description => 'Whether the service is enabled to start at boot.', > + }, > + 'service' => { > + type => 'string', > + description => 'Systemd unit name (e.g., pveproxy).', While not wrong, this is actually what we refer to the systemd unit too, i.e. it might resolve to a different name if we use a (outdated) alias or the like. But not really relevant and hard to encode into the description, so fine by me as is. > + }, > + 'name' => { > + type => 'string', > + description => 'Short identifier for the service (e.g., "pveproxy").', > + }, > + 'desc' => { > + type => 'string', > + description => 'Human-readable description of the service.', > + }, > + }, > }, > code => sub { > my ($param) = @_; _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel