From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 505A4F9D9
 for <pve-devel@lists.proxmox.com>; Mon, 24 Jul 2023 11:20:53 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 2877DC1B4
 for <pve-devel@lists.proxmox.com>; Mon, 24 Jul 2023 11:20:53 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Mon, 24 Jul 2023 11:20:52 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 67CA343A74
 for <pve-devel@lists.proxmox.com>; Mon, 24 Jul 2023 11:20:52 +0200 (CEST)
Message-ID: <c29ab706-f40b-44bb-a7cd-825b21fdee82@proxmox.com>
Date: Mon, 24 Jul 2023 11:20:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-GB
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Lukas Wagner <l.wagner@proxmox.com>
References: <20230720143236.652292-1-l.wagner@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20230720143236.652292-1-l.wagner@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.076 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pve-devel] [PATCH v4 many 00/69] fix #4156: introduce new
 notification system
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 24 Jul 2023 09:20:53 -0000

On 20/07/2023 16:31, Lukas Wagner wrote:
> # Overview
> 
> The purpose of this patch series is to overhaul the existing mail
> notification infrastructure in Proxmox VE.
> The series replaces calls to 'sendmail' with calls to a
> new, configurable notification module. The module was designed to
> support multiple notification endpoints, 'sendmail' using the system's
> sendmail command being the first one. As a proof of the extensibility
> of the current approach, the 'gotify' [1] plugin was also implemented.
> The patch series also includes groups. They allow to send a notification
> to multiple endpoints at the same time. Furthermore, there are filters.
> Endpoints and groups can configure filters to determine if a notification
> should be sent. For now, filters can only be configured based on notification
> severity.
> 
> A short summary of what is included in this patch series:
>   - Sendmail endpoint plugin: uses the system's `sendmail` command 
>     to send - well - mail. The sendmail plugin sends multi-part mails
>     containing HTML as well as plain text.
>   - Gotify endpoint plugin: sends a notification to a gotify server
>   - Groups: As for any notification event one is only able to select a single
>     target, groups can be created to notify multiply endpoints at the same time
>   - Filters: Endpoints and groups can also have filtering: The filter 
>     can match on the notification's metadata (only severity for now) to 
>     determine if it will be sent or not. Filters can be easily extended in 
>     the future to match on other structured metadata as well.
>   - REST API for managing endpoints, groups and filters
>   - Overhauled GUI for backup jobs/one-off backups - here the use can now 
>     select a notification target
>   - GUI for configuring the other notification events 
>     (APT, replication, fencing) - here the user can configure *when* and
>     *where* to send a notification
>   - Notification rendering based on templates: 
>     From a single template, the system can render notifications to either
>     plain text or HTML.
> 

While I didn't got around for a thorough review, I did some spot checking
of the code here and liked what I saw, nice work!

The base design seems OK and any implementation bug/detail can be fixed
with follow ups, so fine for me to apply (Wolfgang should start soon doing
so, at least the rust backend and perlmod stuff).