From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CDA6A1FF137 for ; Tue, 17 Mar 2026 12:29:54 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 374CFB491; Tue, 17 Mar 2026 12:30:07 +0100 (CET) Message-ID: Date: Tue, 17 Mar 2026 12:29:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v2] s3-client: fix Content-Type for put and copy object requests To: Hannes Laimer , pbs-devel@lists.proxmox.com References: <20260316141940.3576-1-h.laimer@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260316141940.3576-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773746927976 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VKD3DIN3PVKIML37EGHXUHTJYOE5EJCY X-Message-ID-Hash: VKD3DIN3PVKIML37EGHXUHTJYOE5EJCY X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/16/26 3:19 PM, Hannes Laimer wrote: > Use the IANA registered `application/octet-stream` content type instead > of the non-standard `binary/octet` value in put_object. > > Also set Content-Type explicitly in copy_object requests, since some S3 > providers drop all source metadata, including Content-Type, when using > x-amz-metadata-directive REPLACE unless it is explicitly provided. This > caused s3_refresh to fail with "missing header 'content-type'" on such > providers when fetching objects moved via copy_object. > > Setting it unconditionally is safe, since put_object already does the > same. > > Signed-off-by: Hannes Laimer Only one small nit: The header value "application/octet-stream" could have been defined as common constant. Tested by syncing new contents from a local datastore to an s3 datastore backed by Ceph RGW and inspecting the content-type header value in the ceph client logs. Further, moved a group with patches [0] applied again checking the content-type header in the Ceph logs, performed a successful s3-refresh and verification job on the group. [0] https://lore.proxmox.com/pbs-devel/c883656f-d89c-4e9d-97ab-3a47ee966200@proxmox.com/T/#t Reviewed-by: Christian Ebner Tested-by: Christian Ebner