From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <c.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 5862D93F2C
for <pbs-devel@lists.proxmox.com>; Wed, 10 Apr 2024 12:00:43 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 398ABB553
for <pbs-devel@lists.proxmox.com>; Wed, 10 Apr 2024 12:00:13 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pbs-devel@lists.proxmox.com>; Wed, 10 Apr 2024 12:00:10 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2142B43C1A
for <pbs-devel@lists.proxmox.com>; Wed, 10 Apr 2024 12:00:10 +0200 (CEST)
Message-ID: <c09aacfd-f9e7-4310-88d4-dcea4819a993@proxmox.com>
Date: Wed, 10 Apr 2024 12:00:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>,
pbs-devel@lists.proxmox.com
References: <20240328123707.336951-1-c.ebner@proxmox.com>
<20240328123707.336951-52-c.ebner@proxmox.com>
<171231043116.1926770.8913431270614969709@yuna.proxmox.com>
Content-Language: en-US, de-DE
From: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <171231043116.1926770.8913431270614969709@yuna.proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.030 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 51/58] pxar: create: show
chunk injection stats debug output
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
<pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>,
<mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 10 Apr 2024 10:00:43 -0000
On 4/5/24 11:47, Fabian Grünbichler wrote:
> Quoting Christian Ebner (2024-03-28 13:37:00)
>> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>> ---
>> changes since version 2:
>> - not present in previous version
>>
>> pbs-client/src/pxar/create.rs | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs
>> index f103127c4..461509c39 100644
>> --- a/pbs-client/src/pxar/create.rs
>> +++ b/pbs-client/src/pxar/create.rs
>> @@ -407,6 +407,14 @@ where
>> encoder.finish().await?;
>> encoder.close().await?;
>>
>> + log::info!(
>> + "Total injected: {} ({} chunks), total reused payload: {}, padding: {} ({} partial chunks)",
>
> we already discussed this off-list, but something like
>
> Change detection: processed XX files, YY unmodified (reused AA GB data + BB GB padding = CC GB total in DD chunks)
>
> and only printing it with change detection metadata is probably easier to
> understand, but maybe we should get some more feedback on that as well :)
>
Adapted this as suggested for the new version of the patches, opted
however for splitting it into 2 lines:
- number of processed and unmodified files
- reused data, padding and total, as well as number of reused chunks and
partial chunks
This output is now only shown when there is a payload writer available
and the second line is not shown if there was no reused data.