From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 34E231FF0B6 for ; Thu, 12 Nov 2026 08:56:39 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7A22621652; Thu, 12 Nov 2026 08:56:34 +0100 (CET) Date: Thu, 12 Nov 2026 08:56:25 +0100 From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: Re: [PATCH container/docs/firewall/manager/network/qemu-server v6 00/28] handle dangling references when firewall objects go away Message-ID: References: <20261111131901.1791124-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261111131901.1791124-1-a.bied-charreton@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794470187017 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.596 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZDVJIM5OVX5T3QCORE2CXOG4TBGN5BEE X-Message-ID-Hash: ZDVJIM5OVX5T3QCORE2CXOG4TBGN5BEE X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Nov 11, 2026 at 02:18:33PM +0100, Arthur Bied-Charreton wrote: > Renaming or deleting a firewall object (an IPSet, alias or security > group) that rules still reference leaves those references dangling. > > The firewall fails to parse the affected rules and drops them from the > generated ruleset. For security groups, the reference reaches the > backend, which creates empty chains on iptables, and causes the ruleset > to fail to load on nftables [1]. > > This is especially bad in the rename case, where one might reasonably > expect the references to follow the new object name and walk away > thinking the firewall rules are active. > > This series makes the affected operations offer to deal with the > references instead of leaving them behind with the following API > options: found a few more issues, v7 incoming