From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3B3121FF183 for ; Wed, 10 Sep 2025 09:47:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0BEEA19A32; Wed, 10 Sep 2025 09:47:29 +0200 (CEST) Date: Wed, 10 Sep 2025 09:47:25 +0200 From: Wolfgang Bumiller To: Dominik Csapak Message-ID: References: <20250910062530.138192-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250910062530.138192-1-d.csapak@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1757490421321 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [tree.rs] Subject: [pdm-devel] applied: [PATCH datacenter-manager] fix #6782: ui: pve: tree: don't show start/shutdown buttons for templates X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Cc: pdm-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" applied, thanks On Wed, Sep 10, 2025 at 08:25:24AM +0200, Dominik Csapak wrote: > templates cannot be started/stopped so don't show these actions > > Signed-off-by: Dominik Csapak > --- > ui/src/pve/tree.rs | 26 +++++++++++++++++--------- > 1 file changed, 17 insertions(+), 9 deletions(-) > > diff --git a/ui/src/pve/tree.rs b/ui/src/pve/tree.rs > index 168e322..2f307e8 100644 > --- a/ui/src/pve/tree.rs > +++ b/ui/src/pve/tree.rs > @@ -610,7 +610,7 @@ fn columns( > ( > r.id.as_str(), > local_id, > - Some((guest_info, r.status.as_str())), > + Some((guest_info, r.status.as_str(), r.template)), > Some(r.node.clone()), > ) > } > @@ -620,7 +620,7 @@ fn columns( > ( > r.id.as_str(), > local_id, > - Some((guest_info, r.status.as_str())), > + Some((guest_info, r.status.as_str(), r.template)), > Some(r.node.clone()), > ) > } > @@ -641,9 +641,12 @@ fn columns( > > Row::new() > .class(JustifyContent::FlexEnd) > - .with_optional_child(guest_info.map(|(_, status)| { > + .with_optional_child(guest_info.and_then(|(_, status, template)| { > + if template { > + return None; > + } > let disabled = status != "running"; > - Tooltip::new( > + let icon = Tooltip::new( > ActionIcon::new("fa fa-fw fa-power-off") > .disabled(disabled) > .on_activate({ > @@ -658,11 +661,15 @@ fn columns( > }) > .class((!disabled).then_some(ColorScheme::Error)), > ) > - .tip(tr!("Shutdown")) > + .tip(tr!("Shutdown")); > + Some(icon) > })) > - .with_optional_child(guest_info.map(|(_, status)| { > + .with_optional_child(guest_info.and_then(|(_, status, template)| { > + if template { > + return None; > + } > let disabled = status == "running"; > - Tooltip::new( > + let icon = Tooltip::new( > ActionIcon::new("fa fa-fw fa-play") > .disabled(disabled) > .on_activate({ > @@ -677,9 +684,10 @@ fn columns( > }) > .class((!disabled).then_some(ColorScheme::Success)), > ) > - .tip(tr!("Start")) > + .tip(tr!("Start")); > + Some(icon) > })) > - .with_optional_child(guest_info.map(|(guest_info, _)| { > + .with_optional_child(guest_info.map(|(guest_info, _, _)| { > Tooltip::new(ActionIcon::new("fa fa-fw fa-paper-plane-o").on_activate({ > let link = link.clone(); > move |_| link.change_view(Some(ViewState::MigrateWindow(guest_info))) > -- > 2.47.3 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel