From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id BE4421FF13E for ; Fri, 03 Apr 2026 10:35:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4CE7A37E85; Fri, 3 Apr 2026 10:35:50 +0200 (CEST) Message-ID: Date: Fri, 3 Apr 2026 10:35:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-backup 12/20] ui: define and expose encryption key management menu item and windows To: Thomas Lamprecht , Christian Ebner , pbs-devel@lists.proxmox.com References: <20260401075521.176354-1-c.ebner@proxmox.com> <20260401075521.176354-13-c.ebner@proxmox.com> <24c14976-d2a2-439a-a089-249725526d6e@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <24c14976-d2a2-439a-a089-249725526d6e@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775205256880 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ERZBVC3PAKQSZX5PGBBWTS7UHQHN7QNG X-Message-ID-Hash: ERZBVC3PAKQSZX5PGBBWTS7UHQHN7QNG X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/2/26 1:08 AM, Thomas Lamprecht wrote: > Am 01.04.26 um 09:55 schrieb Christian Ebner: >> diff --git a/www/config/EncryptionKeysView.js b/www/config/EncryptionKeysView.js > >> + listeners: { >> + activate: 'reload', >> + itemdblclick: 'editEncryptionKeys', > > This should be pbsEncryptionKeysEdit > >> + }, > > > > actually i think the name is already correct, but it is simply not implemented. there'd have to be some method 'editEncryptionKeys' that spawns an edit window. but looking at the code there, it seems it's not intended for editing the keys (what should be edited exactly) so IMHO this line should just be removed