From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0ACEF1FF137 for ; Tue, 31 Mar 2026 14:29:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 862591BDA6; Tue, 31 Mar 2026 14:29:41 +0200 (CEST) Message-ID: Date: Tue, 31 Mar 2026 14:29:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup v5 8/9] ui: add move namespace action To: Dominik Csapak , pbs-devel@lists.proxmox.com References: <20260319161325.206846-1-h.laimer@proxmox.com> <20260319161325.206846-9-h.laimer@proxmox.com> <2290f062-22b9-48ae-b43c-9e7bca683497@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <2290f062-22b9-48ae-b43c-9e7bca683497@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774960122397 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.083 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: R6YLPAQJAISOW23XREV5U65XO6O2SFZP X-Message-ID-Hash: R6YLPAQJAISOW23XREV5U65XO6O2SFZP X-MailFrom: h.laimer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-03-24 11:56, Dominik Csapak wrote: > looks mostly fine > > preexisting but slightly confusing: > > the action of a namespace can only be done from that namespace itself, > not from one level above. maybe it would be sensible to make > that possible as well? > > otherwise one comment inline > > On 3/19/26 5:13 PM, Hannes Laimer wrote: >> When moving a namespace, exclude the source namespace and its subtree >> from the 'New Parent' selector. >> >> Signed-off-by: Hannes Laimer >> --- [..] >>   @@ -1113,10 +1135,13 @@ Ext.define('PBS.DataStoreContent', { >>                           if (data.ty === 'group') { >>                               return Ext.String.format(gettext("Move >> group '{0}'"), v); >>                           } >> -                        return ''; >> +                        return Ext.String.format(gettext("Move >> namespace '{0}'"), v); > > this tooltip is shown for all entries when hovering, even when he icon > is not visible, probably due to it never being disabled > > i think verify and remove have the same problem... > yup, they do. can do a follow-up