From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 42DD17252C
for <pmg-devel@lists.proxmox.com>; Mon, 12 Apr 2021 15:45:36 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 342151FA1E
for <pmg-devel@lists.proxmox.com>; Mon, 12 Apr 2021 15:45:36 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 68B491FA11
for <pmg-devel@lists.proxmox.com>; Mon, 12 Apr 2021 15:45:35 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 28EFB45A15
for <pmg-devel@lists.proxmox.com>; Mon, 12 Apr 2021 15:45:35 +0200 (CEST)
Message-ID: <bceb3499-e9c4-f525-4f30-11959b591378@proxmox.com>
Date: Mon, 12 Apr 2021 15:45:33 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:88.0) Gecko/20100101
Thunderbird/88.0
Content-Language: en-US
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
References: <20210412132359.30151-1-s.ivanov@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20210412132359.30151-1-s.ivanov@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.042 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pmg-devel] [PATCH pmg-api] acme: allow wildcard domain entries
X-BeenThere: pmg-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Mail Gateway development discussion
<pmg-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pmg-devel/>
List-Post: <mailto:pmg-devel@lists.proxmox.com>
List-Help: <mailto:pmg-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel>,
<mailto:pmg-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2021 13:45:36 -0000
On 12.04.21 15:23, Stoiko Ivanov wrote:
> Reported in our community forum [0], support for wildcard certificates
> via ACME sounds like a good enhancement (especially for PMG).
>
> In order for this to work you need to configure both:
> * the wild-card subentry (*.domain.example)
> * the base entry (domain.example)
why the base one though?
Any how, would def. warrant a patch to the docs, else this is a bit obscure.
> as ACME domains (and be able to verify both of them via DNS Plugin)
>
> Quickly tested with a domain of mine (and the powerdns plugin)
>
> [0]
> https://forum.proxmox.com/threads/feature-request-add-wildcard-support-for-acme.87495/
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/PMG/CertHelpers.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PMG/CertHelpers.pm b/src/PMG/CertHelpers.pm
> index 5122f71..b7e79b7 100644
> --- a/src/PMG/CertHelpers.pm
> +++ b/src/PMG/CertHelpers.pm
> @@ -57,7 +57,7 @@ PVE::JSONSchema::register_format('pmg-acme-domain', sub {
>
> my $label = qr/[a-z0-9][a-z0-9_-]*/i;
>
> - return $domain if $domain =~ /^$label(?:\.$label)+$/;
> + return $domain if $domain =~ /^(?:\*\.)?$label(?:\.$label)+$/;
> return undef if $noerr;
> die "value '$domain' does not look like a valid domain name!\n";
> });
>