From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C60841FF185 for ; Mon, 21 Jul 2025 14:51:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E66DEDD1; Mon, 21 Jul 2025 14:52:42 +0200 (CEST) Message-ID: Date: Mon, 21 Jul 2025 14:52:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Aaron Lauterer References: <20250715143218.1548306-1-a.lauterer@proxmox.com> <20250715143218.1548306-28-a.lauterer@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250715143218.1548306-28-a.lauterer@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753102321751 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v3 14/14] fix #6068: ui: utils: calculate and render host memory usage correctly X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" IMHO this and the last patch should be combined, since they don't really make sense without each other.. one comment inline: On 7/15/25 16:32, Aaron Lauterer wrote: > First by using the new memhost field if guest is of type qemu and the field is > numerical. > Second by checking in the render function against the 'value' that has > been calculated if we have percentages or bytes. Previously we always > checked the raw record mem data. > > As a result, if the cluster is in a mixed PVE8 / PVE9 situation, for > example during a migration, we will not report any host memory usage, in > numbers or percent, as we don't get the memhost metric from the older > PVE8 hosts. > > Fixes: #6068 (Node Search tab incorrect Host memory usage %) > Signed-off-by: Aaron Lauterer > --- > www/manager6/Utils.js | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js > index 29334111..ed41714a 100644 > --- a/www/manager6/Utils.js > +++ b/www/manager6/Utils.js > @@ -1166,6 +1166,9 @@ Ext.define('PVE.Utils', { > return -1; > } > > + if (data.type === 'qemu' && Ext.isNumeric(data.memhost)) { > + return data.memhost / maxmem; > + } > return data.mem / maxmem; > }, > > @@ -1206,9 +1209,12 @@ Ext.define('PVE.Utils', { > var node = PVE.data.ResourceStore.getAt(index); > var maxmem = node.data.maxmem || 0; > > - if (record.data.mem > 1) { > + if (value > 1) { looking at the code, this 'value' seems to be the calculated 'hostmemuse' value, which is calculated by 'calculate_hostmem_usage' and i don't see how that could ever return a value > 1? (it basically calculates 'memory' / 'host max memory' which will always be >= 0 and <= 1) so this change seems wrong to me? > // we got no percentage but bytes > let mem = record.data.mem; > + if (record.data.type === 'qemu' && Ext.isNumeric(record.data.memhost)) { > + mem = record.data.memhost; > + } > if (!record.data.uptime || maxmem === 0 || !Ext.isNumeric(mem)) { > return ''; > } _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel