From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 39A6693BEB for <pve-devel@lists.proxmox.com>; Wed, 22 Feb 2023 11:44:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1B627DDDD for <pve-devel@lists.proxmox.com>; Wed, 22 Feb 2023 11:43:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 22 Feb 2023 11:43:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 455CC480EF for <pve-devel@lists.proxmox.com>; Wed, 22 Feb 2023 11:43:29 +0100 (CET) Message-ID: <b88350f0-d018-edc3-ad2c-a80ddd56c6d1@proxmox.com> Date: Wed, 22 Feb 2023 11:43:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:110.0) Gecko/20100101 Thunderbird/110.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20230222075152.982943-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20230222075152.982943-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-series: [PATCH manager v3 0/6] fix #1408: ui: make tree sorting configurable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 22 Feb 2023 10:44:00 -0000 Am 22/02/2023 um 08:51 schrieb Dominik Csapak: > this series allows configuring the sorting of the resource tree > > options are the sort-field, if guest types are grouped and if templates > are grouped seperately. it's configurable via browser local storage > > the first 2 patches are not really related but popped up during > development > > changes from v2: > * improved browser local storage notice > * added padding between the view selector and the button > > changes from v1: > * drop the datacenter config options for now > * rename TreeSortingEdit into TreeSortingEdit > * since we don't have a fallback besides the default, display the > defauls in the dropdowns > * don't use booleanfield anymore (because of above change) > * rename sp into localStorage > * use fieldDefaults > * refactor stuff into PVE.UIOptions (a new singleton) > * remove storage view > * remove booleanfield() > > Dominik Csapak (6): > ui: remove 'Storage View' > ui: remove unused booleanfield > ui: refactor ui option related methods into UIOptions > ui: refactor refreshing the the resource store/tree > ui: add window for changing tree related options > fix #1408: ui: ResourceTree: sort the tree according to tree-sorting > options > applied, thanks! As talked off-list, I made three small followups 1) make settings button stand less out 2) making window a bit wider and claryfing the field labels (mostly that the type grouping only affects guests) 3) change the bogus url to '#' for the record only, as we also talked off list: it might be nice to apply changes live, so that one can see the effect in the background already. But the current settings are relatively straight forward and after initial setup its unlikely to change, so there's not _that_ much friction as is.