From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 72B511FF17C for ; Wed, 17 Sep 2025 15:38:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 837BB53BB; Wed, 17 Sep 2025 15:38:52 +0200 (CEST) Message-ID: Date: Wed, 17 Sep 2025 15:38:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Shannon Sterz References: <20250731091506.67573-1-s.sterz@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20250731091506.67573-1-s.sterz@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1758116291144 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [country.pl, install.pm] Subject: Re: [pve-devel] [PATCH installer v2] install: don't select a debian mirror based on the country anymore X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 31.07.25 um 11:15 AM schrieb Shannon Sterz: > newer isos ship with new deb822 style repository configurations in > `/etc/apt/sources.list.d/debian.sources` which already use the now > prefered cdn [1]. since setting a mirror like this does not work > anymore due to this change, just remove it to keep using the prefered > cdn. > > [1]: > https://www.debian.org/releases/trixie/release-notes/upgrading.en.html#adding-apt-internet-sources > > Signed-off-by: Shannon Sterz Reviewed-by: Fiona Ebner We could also go ahead and remove adding the mirror information to the country hash in country.pl after this change. html/country.htm also should be updated: The Proxmox Installer automatically makes location-based optimizations, like choosing the nearest mirror to download files from. since it's not the Installer itself doing that anymore. > --- > > changes since v1: > > - instead of adapting how we set mirrors to the new deb822 format, > simply remove this code altogether in favor of using the cdn. > > Proxmox/Install.pm | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm > index 3159dcc..5d77821 100644 > --- a/Proxmox/Install.pm > +++ b/Proxmox/Install.pm > @@ -1316,12 +1316,6 @@ _EOD > symlink("/usr/share/zoneinfo/$timezone", "$targetdir/etc/localtime"); > file_write_all("$targetdir/etc/timezone", "$timezone\n"); > > - # set apt mirror > - if (my $mirror = $iso_env->{locales}->{country}->{$country}->{mirror}) { > - my $fn = "$targetdir/etc/apt/sources.list"; > - syscmd("sed -i 's/ftp\\.debian\\.org/$mirror/' '$fn'"); > - } > - > # create extended_states for apt (avoid cron job warning if that > # file does not exist) > file_write_all("$targetdir/var/lib/apt/extended_states", ''); > -- > 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel