From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id BDADE1FF142
	for <inbox@lore.proxmox.com>; Mon, 02 Mar 2026 19:04:42 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id C84E14AE0;
	Mon,  2 Mar 2026 19:05:43 +0100 (CET)
Message-ID: <b7b13065-11e3-43f7-b914-155b7637c519@proxmox.com>
Date: Mon, 2 Mar 2026 19:05:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH container 7/8] implement per-mountpoint uid/gid mapping
From: Filip Schauer <f.schauer@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
References: <20260223130706.90972-1-f.schauer@proxmox.com>
 <20260223130706.90972-8-f.schauer@proxmox.com>
 <7qfxzacabicb4nqa7dd3lg4yxy5te2wd7kzbc5ygeztk5ttdik@4wqxerxngumw>
 <b6b8fdbc-2d8e-4842-94a1-62c4f5cf4cb5@proxmox.com>
Content-Language: en-US
In-Reply-To: <b6b8fdbc-2d8e-4842-94a1-62c4f5cf4cb5@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1772474686775
X-SPAM-LEVEL: Spam detection results:  0
	AWL                    -1.062 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.012 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  1.188 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED   0.93 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: JWYALRZGEZDVC5HDDNK5B7F6F3O7ELWY
X-Message-ID-Hash: JWYALRZGEZDVC5HDDNK5B7F6F3O7ELWY
X-MailFrom: f.schauer@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On 02/03/2026 17:37, Filip Schauer wrote:
> On 27/02/2026 16:33, Wolfgang Bumiller wrote:
>> We probably want a way to just say "undo the container user
>> namespace". The pre-start hook gets a `$namespaces` hash passed as 3rd
>> parameter, we can just open the user namespace fd there for this
>> purpose.
>
> When `lxc.hook.version = 0` (which seems to be the default), $namespaces
> remains empty. So yes, we could try to get the namespace fd from
> $namespaces, but we would just have to fall back to obtaining the
> namespace manually unless `lxc.hook.version = 1` is set explicitly.

Or we could fix `PVE::LXC::Tools::lxc_hook`, such that it always finds
the namespaces.