From: Dominik Csapak <d.csapak@proxmox.com>
To: Jonas Theisen <j.theisen@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-manager] ui: tag menu: show cluster name instead of undefined in title
Date: Tue, 3 Nov 2026 14:38:21 +0100 [thread overview]
Message-ID: <b743984f-6c06-4302-8843-e0cce72b24e3@proxmox.com> (raw)
In-Reply-To: <20261030100700.82807-2-j.theisen@proxmox.com>
same comment regarding clustername as the other patch,
instead of fixing the clustername, we should simply remove that part here
on guests we also don't show neither the nodename nor the clustername
for example
On 10/30/26 11:07 AM, Jonas Theisen wrote:
> The tag context menu appends the node name to its title if a cluster
> name is set, but no node name is ever passed to it, so clustered
> setups show "(undefined)". Use the cluster name instead, like the
> datacenter context menu does.
>
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
> ---
> www/manager6/dc/CmdMenu.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/dc/CmdMenu.js b/www/manager6/dc/CmdMenu.js
> index 87671adb..5bb4d7d1 100644
> --- a/www/manager6/dc/CmdMenu.js
> +++ b/www/manager6/dc/CmdMenu.js
> @@ -117,7 +117,7 @@ Ext.define('PVE.dc.TagCmdMenu', {
>
> me.title = `${gettext('Tag')} '${me.tag}'`;
> if (PVE.ClusterName?.length) {
> - me.title += ` (${me.nodename})`;
> + me.title += ` (${PVE.ClusterName})`;
> }
>
> me.extraHandlerArgs = {
next prev parent reply other threads:[~2026-11-03 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 10:06 [PATCH pve-manager] fix #5001: ui: add context menu with bulk actions for pools in resource tree Jonas Theisen
2026-10-30 10:06 ` [PATCH pve-manager] ui: tag menu: show cluster name instead of undefined in title Jonas Theisen
2026-11-03 13:38 ` Dominik Csapak [this message]
2026-11-03 13:37 ` [PATCH pve-manager] fix #5001: ui: add context menu with bulk actions for pools in resource tree Dominik Csapak
2026-11-04 10:57 ` Jonas Theisen
2026-11-04 11:19 ` Dominik Csapak
2026-11-04 10:58 ` Jonas Theisen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b743984f-6c06-4302-8843-e0cce72b24e3@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=j.theisen@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.