From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 73EB891571 for <pve-devel@lists.proxmox.com>; Tue, 7 Feb 2023 15:58:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 995B3519E for <pve-devel@lists.proxmox.com>; Tue, 7 Feb 2023 15:58:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Tue, 7 Feb 2023 15:58:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 80E5E45E67 for <pve-devel@lists.proxmox.com>; Tue, 7 Feb 2023 15:58:03 +0100 (CET) Message-ID: <b6c88801-a9f6-1d28-9d96-b4e993452972@proxmox.com> Date: Tue, 7 Feb 2023 15:58:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:110.0) Gecko/20100101 Thunderbird/110.0 Content-Language: de-AT, en-GB To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Leo Nunner <l.nunner@proxmox.com> References: <20221201113257.57225-1-l.nunner@proxmox.com> <20221201113257.57225-2-l.nunner@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20221201113257.57225-2-l.nunner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [plugin.pm, cifsplugin.pm, cephfsplugin.pm] Subject: [pve-devel] applied: [PATCH storage 1/1] fix #2641: allow mounting of CIFS subdirectories X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 07 Feb 2023 14:58:39 -0000 Am 01/12/2022 um 12:32 schrieb Leo Nunner: > CIFS/SMB supports directly mounting subdirectories, so it makes sense to > also allow the --subdir parameter for these storages. The subdir > parameter was moved from CephFSPlugin.pm to Plugin.pm, because it isn't > specific to CephFS anymore. > > Signed-off-by: Leo Nunner <l.nunner@proxmox.com> > --- > PVE/Storage/CIFSPlugin.pm | 39 ++++++++++++++++++++----------------- > PVE/Storage/CephFSPlugin.pm | 4 ---- > PVE/Storage/Plugin.pm | 5 +++++ > 3 files changed, 26 insertions(+), 22 deletions(-) > > the patch does more at once than ideal, I'd recommend doing such things as the signature cleanups, which should not have any change functional effect after all, first - that simplify review and also working with the history (e.g., bisect or just wanting to see how a specific feature was done if adding a similar one). But this was relatively minor crowding here, and I did not wanted to delay this further... so applied, with some cleanups as follow up, thanks! ps. the safer fallback for $subdir would have been a empty string '', as then it'd be 1:1 the exact same value as before if one doesn't have any subdir configured - but lets hope no cifs client/server throws up on a newly added trailing slash.