From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 723671FF141 for ; Fri, 27 Feb 2026 08:59:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1DA33912D; Fri, 27 Feb 2026 09:00:29 +0100 (CET) Message-ID: Date: Fri, 27 Feb 2026 09:00:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH kernel-helper] proxmox-boot: add memtest86 as entry to systemd-boot From: Daniel Herzig To: Stoiko Ivanov , pve-devel@lists.proxmox.com References: <20260225183621.201783-1-s.ivanov@proxmox.com> <5182dc93-3a02-4cc9-8e02-dfb6959ef00d@proxmox.com> Content-Language: en-US In-Reply-To: <5182dc93-3a02-4cc9-8e02-dfb6959ef00d@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772179204745 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.668 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1.158 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.306 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.668 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TDLY4JD4YMWGGGUQKCVRJEA25FASFTJF X-Message-ID-Hash: TDLY4JD4YMWGGGUQKCVRJEA25FASFTJF X-MailFrom: d.herzig@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/26/26 2:39 PM, Daniel Herzig wrote: > thanks -- works as expected for my RAIDz1 2-disk setup! For if anyone wonders -- there's a 'z' that sneaked in here. I initially tested against a ZFS RAID 1 two-disk mirror. Just to make sure, I now also tested against a ZFS RAIDz-1 three-disk installation. As expected, the patch works fine for that as well. > > Although not in the scope of this patch, I want to note that the entry > is not created for ZFS GRUB installations (be it on legacy non-EFI, or > secure-boot EFI), as opposed to LVM GRUB installations. > > Tested-by: Daniel Herzig > > On 2/25/26 7:37 PM, Stoiko Ivanov wrote: >> memtest86+ ships a config-snippet for grub configuration, and is thus >> present on installations using grub (although currently not functional >> when secure-boot is enabled). >> >> adding an equivalent entry for memtest86+ on systemd-booted systems >> seems like an improvment and a step to having similar functionality in >> our different boot-loader setups. >> >> Tested by installing proxmox-kernel-helper with this patch and running >> proxmox-boot-tool reinit, followed by rebooting into memtest86+ on a >> systemd-booted system. >> >> Suggested-by: Daniel Herzig >> Signed-off-by: Stoiko Ivanov >> --- >> not 100% sure if it's worth adding, but both Daniel and I thought >> this might >> exist and I remember missing it once on a host of mine >> >>   src/bin/proxmox-boot-tool | 11 +++++++++++ >>   1 file changed, 11 insertions(+) >> >> diff --git a/src/bin/proxmox-boot-tool b/src/bin/proxmox-boot-tool >> index 95d699d..b785c7d 100755 >> --- a/src/bin/proxmox-boot-tool >> +++ b/src/bin/proxmox-boot-tool >> @@ -196,6 +196,17 @@ init_bootloader() { >>               echo "timeout 3" > "$esp_mp/$PMX_LOADER_CONF.tmp" >>               echo "default proxmox-*" >> "$esp_mp/$PMX_LOADER_CONF.tmp" >>               mv "$esp_mp/$PMX_LOADER_CONF.tmp" >> "$esp_mp/$PMX_LOADER_CONF" >> +            memtest=memtest86+x64.efi >> +            memtest_conf="$esp_mp/loader/entries/$memtest.conf" >> +            if [ -f "/boot/$memtest" ]; then >> +                echo "Adding $memtest .." >> +                cp "/boot/$memtest" "$esp_mp/EFI/" >> +                cat > "$memtest_conf.tmp" <<- EOF >> +                    title Memory test ($memtest) >> +                    efi   /EFI/$memtest >> +                EOF >> +                mv "$memtest_conf.tmp" "$memtest_conf" >> +            fi >>           fi >>       else >>           echo "Installing grub i386-pc target.." > > > >