Re: [PATCH proxmox-backup v2 20/27] ui: expose assigning encryption key to sync jobs

Thomas Lamprecht
2026-04-11T08:51:32Z

Am 10.04.26 um 18:54 schrieb Christian Ebner:
> diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
> @@ -560,6 +561,35 @@ Ext.define('PBS.window.SyncJobEdit', {
>
> + {
> + xtype: 'pbsEncryptionKeySelector',
> + name: 'associated-key',
> + fieldLabel: gettext('Associated Keys'),

nit: for pull-only jobs the active key field is hidden, so the user only sees
"Associated Keys" with no context. That label does not convey what the keys
are for from a pull perspective. Maybe label it "Decryption Keys" when in pull
direction? That matches the API param name and makes the purpose immediately
clear.

nit: the tab could also use a brief help text or tooltip explaining the
active/associated key relationship and the automatic key retention on rotation,
otherwise users will wonder what "associated" means.