Re: [PATCH proxmox{,-backup} v2 00/27] fix #7251: implement server side encryption support for push sync jobs

Christian Ebner
2026-04-13T07:10:48Z

On 4/11/26 10:50 AM, Thomas Lamprecht wrote:
> Thanks for the rework, good progress overall.
>
> AFAICT, the pull guard against overwriting previously-decrypted snapshots has
> an inverted condition - see my reply on patch 27.
>
> The archive_key handler should check for active push job references like
> delete_key does, and creating a push job with an archived key should fail at
> config time, not at runtime (see patches 10/11).
>
> No unarchive endpoint - if an admin accidentally archives a key, they have to
> edit the config file manually, can be fine, but should be at least documented.
>
> More details in the per-patch replies.

Thanks a lot for the swift review and catching some more issues! Will
send a version 3 as soon as possible to bring this forward.