Re: [PATCH proxmox{,-backup} v2 00/27] fix #7251: implement server side encryption support for push sync jobs

Thomas Lamprecht
2026-04-11T08:51:25Z

Thanks for the rework, good progress overall.

AFAICT, the pull guard against overwriting previously-decrypted snapshots has
an inverted condition - see my reply on patch 27.

The archive_key handler should check for active push job references like
delete_key does, and creating a push job with an archived key should fail at
config time, not at runtime (see patches 10/11).

No unarchive endpoint - if an admin accidentally archives a key, they have to
edit the config file manually, can be fine, but should be at least documented.

More details in the per-patch replies.