Re: [PATCH proxmox-backup v2 25/27] sync: pull: decrypt blob files on pull if encryption key is configured

Thomas Lamprecht
2026-04-11T08:51:36Z

Am 10.04.26 um 18:54 schrieb Christian Ebner:
> diff --git a/src/server/pull.rs b/src/server/pull.rs
> @@ -409,6 +411,49 @@ async fn pull_single_archive<'a>(
>
> + let mut decrypted_tmp_path = tmp_path.clone();
> + decrypted_tmp_path.set_extension("dectmp");
> + let result = proxmox_lang::try_block!({

Good, the .dectmp cleanup on error is handled now - thanks for fixing that from
v1.

The blob decryption computes csum/size here but they seem to be unused? the
new_manifest and the add_file() calls for blobs only appear in patch 27. At
this commit the decrypted file replaces the encrypted one on disk, but the
manifest still carries the encrypted file's checksum.
Consider squashing the manifest registration into this commit, or at least
comment that this is intentionally "disarmed" and completed by the later patch
(similar to how patch 23 documents it for the index writer).