Re: [PATCH v1 proxmox-backup 1/3] datastore: read ctime from didx header instead of using current time

[Dominik Csapak <d.csapak@proxmox.com>]

On 4/28/26 2:25 PM, Robert Obkircher wrote:
> It looks like this was accidentally changed during a refactor in 2020.
> 
> The ctime field is public, so it is not obvious whether anyone depends
> on the broken behavior. The index_ctime accessor only seems to be used
> by inspect_file in proxmox_backup_debug.

not a review, but I made the ctime field private and
compiled with `cargo build --all` and `cargo test --all`
and it showed now errors, so we can assume this field was never used
directly only via the index_ctime accessor

that said, the fix LGTM

> 
> Fixes: 6a7be83efe ("avoid chrono dependency, depend on proxmox 0.3.8")
> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
> ---
>   pbs-datastore/src/dynamic_index.rs | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/pbs-datastore/src/dynamic_index.rs b/pbs-datastore/src/dynamic_index.rs
> index e1ca0eae..288f38b5 100644
> --- a/pbs-datastore/src/dynamic_index.rs
> +++ b/pbs-datastore/src/dynamic_index.rs
> @@ -119,8 +119,6 @@ impl DynamicIndexReader {
>               bail!("got unknown magic number");
>           }
>   
> -        let ctime = proxmox_time::epoch_i64();
> -
>           let index_size = stat.st_size as usize - header_size;
>           let index_count = index_size / 40;
>           if index_count * 40 != index_size {
> @@ -141,7 +139,7 @@ impl DynamicIndexReader {
>               _file: file,
>               size,
>               index,
> -            ctime,
> +            ctime: header.ctime,
>               uuid: header.uuid,
>               index_csum: header.index_csum,
>           })