From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 004211FF138 for ; Wed, 04 Feb 2026 15:43:46 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 74AA316FCA; Wed, 4 Feb 2026 15:44:18 +0100 (CET) Message-ID: Date: Wed, 4 Feb 2026 15:43:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 proxmox-backup 10/16] client: treat minus sign as stdin To: Robert Obkircher , pbs-devel@lists.proxmox.com References: <20260130164552.281581-1-r.obkircher@proxmox.com> <20260130164552.281581-11-r.obkircher@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770216148052 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HW34JSV6LTR72OTNRU7JIVGUQZ5TDPYJ X-Message-ID-Hash: HW34JSV6LTR72OTNRU7JIVGUQZ5TDPYJ X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/4/26 3:00 PM, Robert Obkircher wrote: > > On 2/2/26 13:14, Christian Ebner wrote: >> On 1/30/26 5:45 PM, Robert Obkircher wrote: >>> Treat "-" as an alias for "/dev/stdin". If there is an actual file >>> with that name it can still be read via "./-". >>> >>> Signed-off-by: Robert Obkircher >>> --- >>>   proxmox-backup-client/src/main.rs | 7 +++++++ >>>   1 file changed, 7 insertions(+) >>> >>> diff --git a/proxmox-backup-client/src/main.rs >>> b/proxmox-backup-client/src/main.rs >>> index 7fc711fd..37878b01 100644 >>> --- a/proxmox-backup-client/src/main.rs >>> +++ b/proxmox-backup-client/src/main.rs >>> @@ -845,6 +845,13 @@ async fn create_backup( >>>           } >>>           target_set.insert(target.clone()); >>>   +        // one can still use ./- to refer to an actual file with >>> that name >>> +        let filename = if filename == "-" { >>> +            String::from("/dev/stdin") >> >> should we add a warning here? >> >> This is actually a breaking change, but guarding it behind a flag is >> maybe a bit overkill. We could check if the file exists before >> continuing and if so fail with an appropriate warning/error? > > Another option would be to just require /dev/stdin and print a hint > about that if the user tries to specify "-". What do you think about that? Might be the better option for the time being, yes. And must be documented correctly of course. The '-' shortcut could still be added as breaking change in a future version. But now I'm wondering, how is the multi archive case handled if reading from stdin? To extend your example in the cover letter: `ssh host cmd | proxmox-backup-client backup a.img:/dev/stdin b.img:/dev/stdin` Without having tested it I guess this will fail on the second archive creation since that will be empty? This should be checked and fail on command invocation instead. > The only real advantage of "-" is that it could be implemented in a> platform independent way by reading from io::stdin(). That would > require a lot of changes though. > >> >>> +        } else { >>> +            filename >>> +        }; >>> + >>>           use std::os::unix::fs::FileTypeExt; >>>             let metadata = std::fs::metadata(&filename) >>