From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5216B1FF13F for ; Thu, 07 May 2026 14:25:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0501F17B5F; Thu, 7 May 2026 14:25:00 +0200 (CEST) Message-ID: Date: Thu, 7 May 2026 14:24:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server v4 07/17] cpu config: set 'type' field before writing To: Arthur Bied-Charreton , pve-devel@lists.proxmox.com References: <20260430160109.565536-1-a.bied-charreton@proxmox.com> <20260430160109.565536-8-a.bied-charreton@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260430160109.565536-8-a.bied-charreton@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778156554945 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LSGQARDYCSQMAMXW5RBEIQSB7AMBP4BE X-Message-ID-Hash: LSGQARDYCSQMAMXW5RBEIQSB7AMBP4BE X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 30.04.26 um 6:00 PM schrieb Arthur Bied-Charreton: > Fix write_config by adding 'type' to every section, otherwise SectionConfig > fails, because it requires each entry in $cfg->{ids} to have a 'type' > key. > > Signed-off-by: Arthur Bied-Charreton > --- > src/PVE/QemuServer/CPUConfig.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PVE/QemuServer/CPUConfig.pm b/src/PVE/QemuServer/CPUConfig.pm > index 78603acc..b606aaa5 100644 > --- a/src/PVE/QemuServer/CPUConfig.pm > +++ b/src/PVE/QemuServer/CPUConfig.pm > @@ -537,6 +537,7 @@ sub write_config { > > # saved in section header > delete $model_conf->{cputype}; > + $model_conf->{type} = $class->type(); Maybe we should rather call check_config() in the API endpoints like other section config users do? Or would that not work nicely here? > } > > $class->SUPER::write_config($filename, $cfg);