Re: [PATCH storage 1/2] add subroutine to classify volume ids

[Fiona Ebner <f.ebner@proxmox.com>]

Am 31.07.26 um 12:13 PM schrieb Fiona Ebner:
> Am 28.07.26 um 2:22 PM schrieb Thomas Ellmenreich:
>> +sub classify_volume_id {
> 
> As already resulted from the other discussion, the current
> implementation is rather for a classify_drive() helper. Technically, an

Or rather classify_drive_file() since it does not look at the whole drive.

> absolute path is not a valid volume ID. Our storage layer just sometimes
> does not cleanly separate them.
> 
>> +    my ($volid, $noerr) = @_;
>> +
>> +    if (!defined($volid) || $volid eq "none") {
> 
> I think we should die for undef and make sure that we always do have an
> explicit value when calling this function. It's not the same for the
> pve-volume-id-or-qm-path format. The result from parse_drive() will
> always have a value and otherwise something went wrong and most likely
> points to another issue that should be resolved.
> 
>> +        return VOL_NONE;
>> +    } elsif ($volid eq 'cdrom') {
>> +        return VOL_CDROM;
>> +    } elsif ($volid =~ m|^/|) {
>> +        return VOL_ABSOLUTE;
>> +    } elsif (parse_volume_id($volid, 1)) {
>> +        return VOL_VOLUME;
>> +    }
>> +
>> +    return undef if $noerr;
>> +    die "unable to classify volume ID '$volid'";
>> +}
>> +
>>  PVE::JSONSchema::register_format('pve-dir-override', \&verify_dir_override);
>>  
>>  sub verify_dir_override {
> 
> 
> 
> 
>