From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D35521FF146 for ; Tue, 07 Jul 2026 09:08:15 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C74C221442; Tue, 07 Jul 2026 09:08:14 +0200 (CEST) Message-ID: Date: Tue, 7 Jul 2026 09:07:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH storage v4 2/2] nfs: use rpcinfo as a showmount fallback for nfs3 To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260706143638.509139-1-m.sandoval@proxmox.com> <20260706143638.509139-3-m.sandoval@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260706143638.509139-3-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1783408052080 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.039 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JEF2QMTYN5HBDOJM3IJIRERV3GC3UGPJ X-Message-ID-Hash: JEF2QMTYN5HBDOJM3IJIRERV3GC3UGPJ X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 06.07.26 um 4:37 PM schrieb Maximiliano Sandoval: > The check_connection call must succeed in order for the NFS storage to > be activated. In a setup in which the NFS server does not list exports > and which only supports NFSv3 this would result in the storage not being > usable (not without manually mounting the NFS share and using a > Directory storage instead). We add a fallback check with rpcinfo for > this case. > > The rpcinfo check was replaced with showmount in f8b0d82f. At the time > the rationale was that rpcinfo did not have support for ipv6 > connections, which does not hold anymore. > > In order to not break compatibility with setups that already activate > correctly, we add a rpcinfo check as a fallback for NFSv3-only setups > only after the showmount command fails. > > Signed-off-by: Maximiliano Sandoval > --- > src/PVE/Storage/NFSPlugin.pm | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/PVE/Storage/NFSPlugin.pm b/src/PVE/Storage/NFSPlugin.pm > index 56dbd9ec..4fe7695a 100644 > --- a/src/PVE/Storage/NFSPlugin.pm > +++ b/src/PVE/Storage/NFSPlugin.pm > @@ -198,6 +198,11 @@ sub check_connection { > # no exports are listed > $cmd = $nfs_get_rpcinfo_command->($server, '4'); > } else { > + # FIXME: PVE 10: Consider switching to rpcinfo altogether. > + # There are some potential pitfalls: > + # - Some NFSv3 servers might only support UDP (cf. RFC 1813, Section 2.3) > + # - The two timeouts add up to a potential worst-case scenario of 20 seconds This is not a pitfall for to the switch to rpcinfo, but related to your current implementation with showmount+rpcinfo. It's rather easy to spot, so not sure it needs a comment in the code. I'd rather have it in the commit message. > + # - Some NFSv4-only servers might not have rpcbind as described at commit acff8954 This is already addressed by the current implementation. If you want to add such a comment, it should rather be in the fallback branch for v4. > $cmd = ['/sbin/showmount', '--no-headers', '--exports', $server]; > } > > @@ -214,6 +219,12 @@ sub check_connection { > return 0 if $port == 0; > > return PVE::Network::tcp_ping($server, $port, 2); > + } else { > + $cmd = $nfs_get_rpcinfo_command->($server, '3'); > + eval { > + run_command($cmd, timeout => 10, outfunc => sub { }, errfunc => sub { }); > + }; > + return 1 if !$@; > } > return 0; > }