all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Jonas Theisen <j.theisen@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: Re: SPAM: [PATCH datacenter-manager] api: local/remote tasks: simplify errors/statusfilter logic
Date: Mon, 31 Aug 2026 14:21:37 +0200	[thread overview]
Message-ID: <b44acb6d-0ff8-4ebd-8ad7-50db7f12936b@proxmox.com> (raw)
In-Reply-To: <20260831114554.831287-1-l.wagner@proxmox.com>

On 8/31/26 13:45, Lukas Wagner wrote:
> `errors` is semantically a subset of `statusfilter`, so we can simplify
> the code quite a bit if we include the behavior controlled by `errors`
> into `statusfilter` and then only filter based on the latter.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
>
> -snip-

Tested the filters with the patch on both Remotes -> Tasks
and {Nodename} -> Tasks and works fine on both pages.
Also tested combinations with "Task type" filters and works
as expected.

For reference PDM is configured with a PVE and a PBS remote.
--
Tested-by: Jonas Theisen <j.theisen@proxmox.com>




      reply	other threads:[~2026-08-31 12:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 11:45 SPAM: [PATCH datacenter-manager] api: local/remote tasks: simplify errors/statusfilter logic Lukas Wagner
2026-08-31 12:21 ` Jonas Theisen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b44acb6d-0ff8-4ebd-8ad7-50db7f12936b@proxmox.com \
    --to=j.theisen@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal